Skip to content

Implement Console grouping APIs.#27088

Merged
bors-servo merged 1 commit intoservo:masterfrom
jdm:group
Jul 7, 2020
Merged

Implement Console grouping APIs.#27088
bors-servo merged 1 commit intoservo:masterfrom
jdm:group

Conversation

@jdm
Copy link
Copy Markdown
Member

@jdm jdm commented Jun 25, 2020

These are used by Hubs and other sites we want to run.


@highfive
Copy link
Copy Markdown

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/globalscope.rs, components/script/dom/webidls/Console.webidl, components/script/dom/console.rs
  • @KiChjang: components/script/dom/globalscope.rs, components/script/dom/webidls/Console.webidl, components/script/dom/console.rs

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jun 25, 2020
@highfive
Copy link
Copy Markdown

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!

Copy link
Copy Markdown
Member

@CYBAI CYBAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found wrong spec link 👀

@jdm
Copy link
Copy Markdown
Member Author

jdm commented Jun 30, 2020

r? @ferjm

Copy link
Copy Markdown
Contributor

@ferjm ferjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with the spec links fixed

* © Copyright 2014 Mozilla Foundation.
*/

// https://console.spec.whatwg.org/
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdm
Copy link
Copy Markdown
Member Author

jdm commented Jul 6, 2020

@bors-servo r=ferjm

@bors-servo
Copy link
Copy Markdown
Contributor

📌 Commit 09c7dae has been approved by ferjm

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jul 6, 2020
@jdm
Copy link
Copy Markdown
Member Author

jdm commented Jul 6, 2020

@bors-servo r-

@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Jul 6, 2020
@jdm
Copy link
Copy Markdown
Member Author

jdm commented Jul 6, 2020

@bors-servo r=ferjm

@bors-servo
Copy link
Copy Markdown
Contributor

📌 Commit 2d7effd has been approved by ferjm

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jul 6, 2020
@bors-servo
Copy link
Copy Markdown
Contributor

⌛ Testing commit 2d7effd with merge 713b26a...

bors-servo added a commit that referenced this pull request Jul 7, 2020
Implement Console grouping APIs.

These are used by Hubs and other sites we want to run.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #9274
- [x] These changes do not require tests because we can't test stdout content or devtools messages.
@bors-servo
Copy link
Copy Markdown
Contributor

💔 Test failed - status-taskcluster

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Jul 7, 2020
@jdm
Copy link
Copy Markdown
Member Author

jdm commented Jul 7, 2020

@bors-servo
Copy link
Copy Markdown
Contributor

⌛ Testing commit 2d7effd with merge a630944...

bors-servo added a commit that referenced this pull request Jul 7, 2020
Implement Console grouping APIs.

These are used by Hubs and other sites we want to run.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #9274
- [x] These changes do not require tests because we can't test stdout content or devtools messages.
@highfive highfive removed the S-tests-failed The changes caused existing tests to fail. label Jul 7, 2020
@highfive highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jul 7, 2020
@bors-servo
Copy link
Copy Markdown
Contributor

💔 Test failed - status-taskcluster

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Jul 7, 2020
@jdm
Copy link
Copy Markdown
Member Author

jdm commented Jul 7, 2020

@bors-servo
Copy link
Copy Markdown
Contributor

⌛ Testing commit 2d7effd with merge cbbbe16...

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Jul 7, 2020
@bors-servo
Copy link
Copy Markdown
Contributor

☀️ Test successful - status-taskcluster
Approved by: ferjm
Pushing cbbbe16 to master...

@bors-servo bors-servo merged commit cbbbe16 into servo:master Jul 7, 2020
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jul 7, 2020
@bors-servo bors-servo mentioned this pull request Jul 7, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement console.group() / console.groupEnd() / console.groupCollapsed()

5 participants