Focus correctness improvements#26902
Merged
bors-servo merged 2 commits intoservo:masterfrom Jun 15, 2020
Merged
Conversation
|
Heads up! This PR modifies the following files:
|
highfive
added
the
S-awaiting-review
Member
Author
|
@bors-servo try=wpt |
bors-servo
added a commit
that referenced
this pull request
Jun 12, 2020
Focus correctness improvements These changes improve the behaviour of focus in Hubs rooms, and are expected to improve web compat around other dynamic pages that receive keyboard events as well. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #26901 and fix #26900. - [x] There are tests for these changes
Contributor
Contributor
|
💔 Test failed - status-taskcluster |
Member
|
tidy is complaining about the spec urls 👀 Open to see WPT failures |
Member
Author
|
@bors-servo try=wpt |
Contributor
bors-servo
added a commit
that referenced
this pull request
Jun 13, 2020
Focus correctness improvements These changes improve the behaviour of focus in Hubs rooms, and are expected to improve web compat around other dynamic pages that receive keyboard events as well. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #26901 and fix #26900. - [x] There are tests for these changes
Contributor
|
💔 Test failed - status-taskcluster |
Member
|
the failure is #25476 |
nox
reviewed
Jun 15, 2020
| )) | | ||
| NodeTypeId::Element(ElementTypeId::HTMLElement( | ||
| HTMLElementTypeId::HTMLTextAreaElement, | ||
| )) => true, |
Contributor
There was a problem hiding this comment.
Just a random thought: would be nice to generate associated constants on NodeTypeId to do stuff such as NodeTypeID::TEXT_AREA.
nox
reviewed
Jun 15, 2020
| if implicit_transaction { | ||
| self.begin_focus_transaction(); | ||
| } | ||
| if elem.map_or(true, |e| e.is_focusable_area()) { |
Contributor
There was a problem hiding this comment.
I'm not sure I understand what it means to focus a None element.
Member
Author
There was a problem hiding this comment.
De-focus the currently focused element.
Contributor
|
LGTM but there was a try failure. |
Member
Author
|
@bors-servo r=nox |
Contributor
|
📌 Commit d55424e has been approved by |
highfive
added
S-awaiting-merge
Contributor
Contributor
|
☀️ Test successful - status-taskcluster |
highfive
removed
the
S-awaiting-merge
4 tasks
This was referenced Jun 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes improve the behaviour of focus in Hubs rooms, and are expected to improve web compat around other dynamic pages that receive keyboard events as well.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors