Generate keyup events for printable keys#26901
Merged
bors-servo merged 1 commit intoservo:masterfrom Jun 13, 2020
Merged
Conversation
highfive
added
the
S-awaiting-review
Manishearth
approved these changes
Jun 12, 2020
Member
|
@bors-servo r+ |
Contributor
|
📌 Commit 87724ec has been approved by |
highfive
added
S-awaiting-merge
bors-servo
added a commit
that referenced
this pull request
Jun 12, 2020
Focus correctness improvements These changes improve the behaviour of focus in Hubs rooms, and are expected to improve web compat around other dynamic pages that receive keyboard events as well. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #26901 and fix #26900. - [x] There are tests for these changes
Contributor
bors-servo
added a commit
that referenced
this pull request
Jun 13, 2020
Generate keyup events for printable keys - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #26880 - [x] These changes do not require tests because we have no automated way to test user input
Contributor
|
💔 Test failed - status-taskcluster |
highfive
added
S-tests-failed
bors-servo
added a commit
that referenced
this pull request
Jun 13, 2020
Focus correctness improvements These changes improve the behaviour of focus in Hubs rooms, and are expected to improve web compat around other dynamic pages that receive keyboard events as well. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #26901 and fix #26900. - [x] There are tests for these changes
Member
Author
Contributor
bors-servo
added a commit
that referenced
this pull request
Jun 13, 2020
Generate keyup events for printable keys - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #26880 - [x] These changes do not require tests because we have no automated way to test user input
highfive
added
S-awaiting-merge
Contributor
|
💔 Test failed - status-taskcluster |
highfive
added
S-tests-failed
Member
Author
|
@bors-servo retry |
Contributor
highfive
added
S-awaiting-merge
Contributor
|
☀️ Test successful - status-taskcluster |
highfive
removed
the
S-awaiting-merge
bors-servo
added a commit
that referenced
this pull request
Jun 15, 2020
Focus correctness improvements These changes improve the behaviour of focus in Hubs rooms, and are expected to improve web compat around other dynamic pages that receive keyboard events as well. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #26901 and fix #26900. - [x] There are tests for these changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors