Try to avoid panicking during I/O in the signal and panic handlers.#25662
Merged
bors-servo merged 1 commit intoservo:masterfrom Jan 31, 2020
Merged
Try to avoid panicking during I/O in the signal and panic handlers.#25662bors-servo merged 1 commit intoservo:masterfrom
bors-servo merged 1 commit intoservo:masterfrom
Conversation
highfive
added
the
S-awaiting-review
Member
Author
|
r? @SimonSapin |
Member
|
@bors-servo r+ |
Contributor
|
📌 Commit 8fdec5b has been approved by |
highfive
added
S-awaiting-merge
Contributor
bors-servo
pushed a commit
that referenced
this pull request
Jan 31, 2020
Try to avoid panicking during I/O in the signal and panic handlers. A bunch of mac WPT processes are sitting in zombie states where a thread has hit a double panic while printing the backtrace. These changes attempt to prevent this issue by ignoring any I/O failures that occur while printing, instead of panicking. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #25513 - [x] These changes do not require tests because they address an intermittent edge case <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Contributor
|
💔 Test failed - status-taskcluster |
highfive
added
S-tests-failed
Member
Contributor
bors-servo
pushed a commit
that referenced
this pull request
Jan 31, 2020
Try to avoid panicking during I/O in the signal and panic handlers. A bunch of mac WPT processes are sitting in zombie states where a thread has hit a double panic while printing the backtrace. These changes attempt to prevent this issue by ignoring any I/O failures that occur while printing, instead of panicking. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #25513 - [x] These changes do not require tests because they address an intermittent edge case <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
highfive
added
S-awaiting-merge
Contributor
|
☀️ Test successful - status-taskcluster |
highfive
removed
the
S-awaiting-merge
Member
Member
Author
|
No problem; the changes should be an improvement regardless. I think there are multiple problems affecting the mac test results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bunch of mac WPT processes are sitting in zombie states where a thread has hit a double panic while printing the backtrace. These changes attempt to prevent this issue by ignoring any I/O failures that occur while printing, instead of panicking.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors