Skip to content

Update cmake#23927

Merged
bors-servo merged 1 commit intoservo:masterfrom
atouchet:cmake
Aug 7, 2019
Merged

Update cmake#23927
bors-servo merged 1 commit intoservo:masterfrom
atouchet:cmake

Conversation

@atouchet
Copy link
Copy Markdown
Contributor

@atouchet atouchet commented Aug 7, 2019


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #___ (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because ___

This change is Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Aug 7, 2019
@jdm
Copy link
Copy Markdown
Member

jdm commented Aug 7, 2019

@bors-servo r+
Thanks!

@bors-servo
Copy link
Copy Markdown
Contributor

📌 Commit 09d011b has been approved by jdm

@highfive highfive assigned jdm and unassigned nox Aug 7, 2019
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Aug 7, 2019
@bors-servo
Copy link
Copy Markdown
Contributor

⌛ Testing commit 09d011b with merge 555fa75...

bors-servo pushed a commit that referenced this pull request Aug 7, 2019
Update cmake

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23927)
<!-- Reviewable:end -->
@bors-servo
Copy link
Copy Markdown
Contributor

💔 Test failed - linux-rel-css

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Aug 7, 2019
@jdm
Copy link
Copy Markdown
Member

jdm commented Aug 7, 2019

@bors-servo retry

@bors-servo
Copy link
Copy Markdown
Contributor

⚡ Previous build results for linux-rel-wpt, status-taskcluster are reusable. Rebuilding only linux-rel-css...

@bors-servo
Copy link
Copy Markdown
Contributor

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing 555fa75 to master...

@bors-servo bors-servo merged commit 09d011b into servo:master Aug 7, 2019
@atouchet atouchet deleted the cmake branch August 7, 2019 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-tests-failed The changes caused existing tests to fail.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants