Skip to content

Revert "Replace use of callbacks in webxr by channels"#23874

Closed
SimonSapin wants to merge 1 commit intomasterfrom
revert
Closed

Revert "Replace use of callbacks in webxr by channels"#23874
SimonSapin wants to merge 1 commit intomasterfrom
revert

Conversation

@SimonSapin
Copy link
Copy Markdown
Member

@SimonSapin SimonSapin commented Jul 28, 2019 •
edited
Loading

This backs out commit 133a17e / PR #23848 because it relies on a git branch that was apparently removed:

$ cargo fetch
    Updating git repository `https://github.com/asajeffrey/webxr`
error: failed to resolve patches for `https://github.com/servo/webxr`

Caused by:
  failed to load source for a dependency on `webxr`

Caused by:
  Unable to update https://github.com/asajeffrey/webxr?branch=optional-glsync#da820a3a

Caused by:
  revspec 'da820a3ab266fce07c9a8abee3e6e9231cb93ec5' not found; class=Reference (4); code=NotFound (-3)

This change is Reviewable

@SimonSapin
Revert "Replace use of callbacks in webxr by channels"
c0971b1 
This backs out commit 133a17e / PR #23848
because it relies on a git branch that was apparently removed:

```
$ cargo fetch
    Updating git repository `https://github.com/asajeffrey/webxr`
error: failed to resolve patches for `https://github.com/servo/webxr`

Caused by:
  failed to load source for a dependency on `webxr`

Caused by:
  Unable to update https://github.com/asajeffrey/webxr?branch=optional-glsync#da820a3a

Caused by:
  revspec 'da820a3ab266fce07c9a8abee3e6e9231cb93ec5' not found; class=Reference (4); code=NotFound (-3)
```
@SimonSapin
Copy link
Copy Markdown
Member Author

SimonSapin commented Jul 28, 2019

@bors-servo r+

CC @asajeffrey, @Manishearth

@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Jul 28, 2019

📌 Commit c0971b1 has been approved by SimonSapin

@highfive highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jul 28, 2019
@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Jul 28, 2019

⌛ Testing commit c0971b1 with merge a323f81...

bors-servo pushed a commit that referenced this pull request Jul 28, 2019
Auto merge of #23874 - servo:revert, r=SimonSapin
a323f81 
Revert "Replace use of callbacks in webxr by channels"

This backs out commit 133a17e / PR #23848 because it relies on a git branch that was apparently removed:

```
$ cargo fetch
    Updating git repository `https://github.com/asajeffrey/webxr`
error: failed to resolve patches for `https://github.com/servo/webxr`

Caused by:
  failed to load source for a dependency on `webxr`

Caused by:
  Unable to update https://github.com/asajeffrey/webxr?branch=optional-glsync#da820a3a

Caused by:
  revspec 'da820a3ab266fce07c9a8abee3e6e9231cb93ec5' not found; class=Reference (4); code=NotFound (-3)
```

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23874)
<!-- Reviewable:end -->
@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Jul 28, 2019

💔 Test failed - linux-rel-css

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Jul 28, 2019
@jdm
Copy link
Copy Markdown
Member

jdm commented Jul 28, 2019

@bors-servo retry

@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Jul 28, 2019

⌛ Testing commit c0971b1 with merge 139e7e8...

bors-servo pushed a commit that referenced this pull request Jul 28, 2019
Auto merge of #23874 - servo:revert, r=SimonSapin
139e7e8 
Revert "Replace use of callbacks in webxr by channels"

This backs out commit 133a17e / PR #23848 because it relies on a git branch that was apparently removed:

```
$ cargo fetch
    Updating git repository `https://github.com/asajeffrey/webxr`
error: failed to resolve patches for `https://github.com/servo/webxr`

Caused by:
  failed to load source for a dependency on `webxr`

Caused by:
  Unable to update https://github.com/asajeffrey/webxr?branch=optional-glsync#da820a3a

Caused by:
  revspec 'da820a3ab266fce07c9a8abee3e6e9231cb93ec5' not found; class=Reference (4); code=NotFound (-3)
```

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23874)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Jul 28, 2019
@jdm
Copy link
Copy Markdown
Member

jdm commented Jul 28, 2019

@bors-servo r-

@jdm
Copy link
Copy Markdown
Member

jdm commented Jul 28, 2019

This will be fixed by #23857.

@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Jul 28, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
State: approved= try=False

@jdm
Copy link
Copy Markdown
Member

jdm commented Jul 28, 2019

@bors-servo treeclosed-

@jdm jdm closed this Jul 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@SimonSapin SimonSapin

Labels

S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SimonSapin @bors-servo @jdm @highfive