Update the url crate to 2.0 by SimonSapin · Pull Request #23838 · servo/servo

SimonSapin · 2019-07-23T17:36:39Z

Blocked on:

Upgrade url to 2.0 housleyjk/ws-rs#283 + undoing corresponding [patch.crates-io] entry

Soft-blocked on: (we could add to the crate duplication allow-list instead)

~~Update the percent-encoding crate to 2.0 rust-windowing/winit#1066~~
- Update the percent-encoding crate to 2.0 in winit v0.19.2 rust-windowing/winit#1076
Update the url crate to 2.0 media#288
Update the ws crate to 0.9 webrender#3720
Update the url crate to 2.0 gobwas/influent.rs#22
https://bugzilla.mozilla.org/show_bug.cgi?id=1568540
- Update tungstenite and serde_urlencoded seanmonstar/warp#260
- Update mime dependencies abonander/multipart#121

This change is

highfive · 2019-07-23T17:36:45Z

Heads up! This PR modifies the following files:

@asajeffrey: components/script/dom/document.rs, components/webdriver_server/Cargo.toml, components/script/Cargo.toml, components/script/dom/htmlformelement.rs, components/script/script_thread.rs
@jgraham: components/webdriver_server/Cargo.toml
@KiChjang: components/net/Cargo.toml, components/script/dom/document.rs, components/net/data_loader.rs, components/script/Cargo.toml, components/net_traits/lib.rs and 4 more

highfive · 2019-07-23T17:36:48Z

Warning

These commits modify net and script code, but no tests are modified. Please consider adding a test!

bors-servo · 2019-07-27T14:00:51Z

☔ The latest upstream changes (presumably #23848) made this pull request unmergeable. Please resolve the merge conflicts.

bors-servo · 2019-08-07T22:07:56Z

☔ The latest upstream changes (presumably #23927) made this pull request unmergeable. Please resolve the merge conflicts.

atouchet · 2019-08-15T02:49:09Z

url ended up being duped in #23853.

SimonSapin · 2019-08-16T12:46:36Z

In that case let’s not wait more to land this, the full dedup can come later.

r? @Manishearth

jdm · 2019-08-16T13:41:38Z

Taskcluster reports build errors.

SimonSapin · 2019-08-16T13:50:25Z

This duplicates the ws crate, which is fixed by servo/webrender#3720

Manishearth · 2019-08-16T14:36:35Z

@bors-servo r+

https://www.youtube.com/watch?v=h6Uht69h8Is

bors-servo · 2019-08-16T14:36:36Z

📋 Looks like this PR is still in progress, ignoring approval

Manishearth · 2019-08-16T14:41:53Z

merge when ready

SimonSapin · 2019-08-16T14:47:33Z

Oh, was that about “WIP” in the title?

@bors-servo r=Manishearth

bors-servo · 2019-08-16T14:47:34Z

📌 Commit ece1085 has been approved by Manishearth

bors-servo · 2019-08-16T16:28:38Z

⌛ Testing commit ece1085 with merge 28c565d...

Update the url crate to 2.0 Blocked on: * [x] housleyjk/ws-rs#283 + undoing corresponding `[patch.crates-io]` entry Soft-blocked on: (we could add to the crate duplication allow-list instead) * [x] ~rust-windowing/winit#1066 - [x] rust-windowing/winit#1076 * [x] servo/media#288 * [ ] servo/webrender#3720 * [x] gobwas/influent.rs#22 * [ ] https://bugzilla.mozilla.org/show_bug.cgi?id=1568540 - [x] seanmonstar/warp#260 - [ ] abonander/multipart#121  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23838)

bors-servo · 2019-08-16T17:14:55Z

💔 Test failed - linux-rel-wpt

SimonSapin · 2019-08-16T18:14:08Z

Updated expectations for /url.

@bors-servo r=Manishearth

bors-servo · 2019-08-16T18:14:09Z

📌 Commit 7d7afb0 has been approved by Manishearth

bors-servo · 2019-08-16T20:14:25Z

⌛ Testing commit 7d7afb0 with merge cd46195...

Update the url crate to 2.0 Blocked on: * [x] housleyjk/ws-rs#283 + undoing corresponding `[patch.crates-io]` entry Soft-blocked on: (we could add to the crate duplication allow-list instead) * [x] ~rust-windowing/winit#1066 - [x] rust-windowing/winit#1076 * [x] servo/media#288 * [ ] servo/webrender#3720 * [x] gobwas/influent.rs#22 * [ ] https://bugzilla.mozilla.org/show_bug.cgi?id=1568540 - [x] seanmonstar/warp#260 - [ ] abonander/multipart#121  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23838)

bors-servo · 2019-08-16T20:59:42Z

💔 Test failed - linux-rel-wpt

jdm · 2019-08-16T21:18:24Z


  ▶ Unexpected subtest result in /url/url-setters.html:
  └ PASS [expected FAIL] URL: Setting <https://x/>.host = '\xdf' IDNA Nontransitional_Processing

  ▶ Unexpected subtest result in /url/url-setters.html:
  └ PASS [expected FAIL] <a>: Setting <https://x/>.host = '\xdf' IDNA Nontransitional_Processing

  ▶ Unexpected subtest result in /url/url-constructor.html:
  └ PASS [expected FAIL] Parsing: <https://fa\xdf.ExAmPlE/> against <about:blank>

  ▶ Unexpected subtest result in /url/a-element.html:
  └ PASS [expected FAIL] Parsing: <https://fa\xdf.ExAmPlE/> against <about:blank>

  ▶ Unexpected subtest result in /url/a-element-xhtml.xhtml:
  └ PASS [expected FAIL] Parsing: <https://fa\xdf.ExAmPlE/> against <about:blank>


  ▶ Unexpected subtest result in /url/url-origin.html:
  └ PASS [expected FAIL] Origin parsing: <https://fa\xdf.ExAmPlE/> against <about:blank>

SimonSapin · 2019-08-17T08:04:31Z

Not sure how those expectations weren’t updated in the previous run…

@bors-servo r=Manishearth

bors-servo · 2019-08-17T08:04:32Z

📌 Commit 734fa6d has been approved by Manishearth

bors-servo · 2019-08-17T08:14:34Z

⌛ Testing commit 734fa6d with merge 9bba14c...

Update the url crate to 2.0 Blocked on: * [x] housleyjk/ws-rs#283 + undoing corresponding `[patch.crates-io]` entry Soft-blocked on: (we could add to the crate duplication allow-list instead) * [x] ~rust-windowing/winit#1066 - [x] rust-windowing/winit#1076 * [x] servo/media#288 * [ ] servo/webrender#3720 * [x] gobwas/influent.rs#22 * [ ] https://bugzilla.mozilla.org/show_bug.cgi?id=1568540 - [x] seanmonstar/warp#260 - [ ] abonander/multipart#121  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23838)

bors-servo · 2019-08-17T10:50:52Z

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: Manishearth
Pushing 9bba14c to master...

SimonSapin added the S-blocked-on-external Something, somewhere else, needs to happen before this PR can be merged. label Jul 23, 2019

highfive assigned paulrouget Jul 23, 2019

highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jul 23, 2019

highfive added the S-needs-rebase There are merge conflict errors. label Jul 27, 2019

SimonSapin force-pushed the url-2.0 branch from ab20d4e to 22b142e Compare August 16, 2019 12:44

SimonSapin removed S-blocked-on-external Something, somewhere else, needs to happen before this PR can be merged. S-needs-rebase There are merge conflict errors. labels Aug 16, 2019

SimonSapin force-pushed the url-2.0 branch 2 times, most recently from 5f9815a to ece1085 Compare August 16, 2019 13:49

highfive assigned Manishearth and unassigned paulrouget Aug 16, 2019

SimonSapin changed the title ~~WIP: Update the url crate to 2.0~~ Update the url crate to 2.0 Aug 16, 2019

highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Aug 16, 2019

SimonSapin force-pushed the url-2.0 branch from ece1085 to 7d7afb0 Compare August 16, 2019 18:14

highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Aug 16, 2019

SimonSapin added 2 commits August 17, 2019 10:03

Update to url 2.0

9392180

Update to percent-encoding 2.0

734fa6d

SimonSapin force-pushed the url-2.0 branch from 7d7afb0 to 734fa6d Compare August 17, 2019 08:03

highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Aug 17, 2019

highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Aug 17, 2019

SimonSapin mentioned this pull request Aug 17, 2019

Update mime dependencies abonander/multipart#121

Closed

bors-servo merged commit 734fa6d into master Aug 17, 2019

highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Aug 17, 2019

bors-servo mentioned this pull request Aug 17, 2019

Implement TakeElementScreenshot WebDriver command #23943

Merged

3 tasks

SimonSapin deleted the url-2.0 branch August 17, 2019 10:52

Uh oh!

Conversation

SimonSapin commented Jul 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

highfive commented Jul 23, 2019

Uh oh!

highfive commented Jul 23, 2019

Uh oh!

bors-servo commented Jul 27, 2019

Uh oh!

bors-servo commented Aug 7, 2019

Uh oh!

atouchet commented Aug 15, 2019

Uh oh!

SimonSapin commented Aug 16, 2019

Uh oh!

jdm commented Aug 16, 2019

Uh oh!

SimonSapin commented Aug 16, 2019

Uh oh!

Manishearth commented Aug 16, 2019

Uh oh!

bors-servo commented Aug 16, 2019

Uh oh!

Manishearth commented Aug 16, 2019

Uh oh!

SimonSapin commented Aug 16, 2019

Uh oh!

bors-servo commented Aug 16, 2019

Uh oh!

bors-servo commented Aug 16, 2019

Uh oh!

bors-servo commented Aug 16, 2019

Uh oh!

SimonSapin commented Aug 16, 2019

Uh oh!

bors-servo commented Aug 16, 2019

Uh oh!

bors-servo commented Aug 16, 2019

Uh oh!

bors-servo commented Aug 16, 2019

Uh oh!

jdm commented Aug 16, 2019

Uh oh!

SimonSapin commented Aug 17, 2019

Uh oh!

bors-servo commented Aug 17, 2019

Uh oh!

bors-servo commented Aug 17, 2019

Uh oh!

bors-servo commented Aug 17, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

SimonSapin commented Jul 23, 2019 •

edited

Loading