Implement srcObject logic for Blob media providers by ferjm · Pull Request #23103 · servo/servo

ferjm · 2019-03-26T14:56:52Z

./mach build -d does not report any errors
./mach test-tidy does not report any errors
There are tests for these changes

This change is

highfive · 2019-03-26T14:56:56Z

Heads up! This PR modifies the following files:

@asajeffrey: components/script/dom/webidls/HTMLMediaElement.webidl, components/script/dom/htmlmediaelement.rs
@KiChjang: components/script/dom/webidls/HTMLMediaElement.webidl, components/script/dom/htmlmediaelement.rs

highfive · 2019-03-26T14:56:59Z

Warning

These commits include an empty title element (<title></title>). Consider adding appropriate metadata.

servo-wpt-sync · 2019-03-26T17:32:37Z

Opened new PR for upstreamable changes.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#16088.

CYBAI · 2019-03-27T01:54:00Z

AppVeyor failed with timeout and Travis complained about WPT manifest 👀

 0:09.30 INFO Diffing old and new manifests /home/travis/build/servo/servo/tests/wpt/mozilla/meta/MANIFEST.json
 0:09.41 /home/travis/build/servo/servo/tests/wpt/mozilla/meta/MANIFEST.json  0  error  mozilla/movie_5.mp4 in manifest but removed from source.  (wpt-manifest)
 0:09.41 ERROR Manifest /home/travis/build/servo/servo/tests/wpt/mozilla/meta/MANIFEST.json is outdated, use |./mach update-manifest| to fix.
 0:09.41 INFO Diffing old and new manifests /home/travis/build/servo/servo/tests/wpt/metadata/MANIFEST.json
 0:15.47 WARNING Manifest /home/travis/build/servo/servo/tests/wpt/metadata/MANIFEST.json contains correct tests but file hashes changed.
 0:15.60 ERROR Manifest /home/travis/build/servo/servo/tests/wpt/metadata/MANIFEST.json is outdated, use |./mach update-manifest| to fix.
 0:15.60 INFO Diffing old and new manifests /home/travis/build/servo/servo/tests/wpt/webgl/meta/MANIFEST.json

CYBAI · 2019-03-27T03:15:08Z

I saw there's a forced push after @jdm labeled the S-needs-rebase so I removed it 🙇

servo-wpt-sync · 2019-03-27T06:13:58Z

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#16088.

ferjm · 2019-03-27T06:14:35Z

@bors-servo try=wpt

bors-servo · 2019-03-27T06:14:39Z

⌛ Trying commit d156400 with merge 32893f8...

Implement srcObject logic for Blob media providers - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23103)

ferjm · 2019-03-27T06:23:19Z

r? @Manishearth

I realize that this might not be very useful for the MediaStream case, as we are using the fetch_request path for blobs as well. I guess we would need to generalize and replicate some of the logic of the FetchResponseListener implementation for HTMLMediaElementFetchListener for the MediaStream and MediaSource cases.

bors-servo · 2019-03-27T06:47:55Z

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
State: approved= try=True

Manishearth · 2019-04-03T07:40:08Z

@bors-servo r+

looks good!

bors-servo · 2019-04-03T07:40:08Z

📌 Commit d156400 has been approved by Manishearth

bors-servo · 2019-04-03T07:40:15Z

⌛ Testing commit d156400 with merge 9454086...

Implement srcObject logic for Blob media providers - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23103)

bors-servo · 2019-04-03T08:14:18Z

💔 Test failed - linux-rel-wpt

CYBAI · 2019-04-03T09:05:29Z

@bors-servo retry

intermittent crash ("Connection reset by peer" from create_api) in /html/semantics/embedded-content/the-canvas-element/2d.getcontext.shared.html, /html/semantics/scripting-1/the-template-element/template-element/node-document-changes.html, /dom/traversal/TreeWalker-walking-outside-a-tree.html, /XMLHttpRequest/responseText-status.html, /_mozilla/css/line_break_nowrap.html #13480

bors-servo · 2019-04-03T09:05:35Z

⌛ Testing commit d156400 with merge b9b729c...

Implement srcObject logic for Blob media providers - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23103)

bors-servo · 2019-04-03T10:36:18Z

☀️ Test successful - android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster
Approved by: Manishearth
Pushing b9b729c to master...

highfive assigned SimonSapin Mar 26, 2019

highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 26, 2019

jdm added the S-needs-rebase There are merge conflict errors. label Mar 26, 2019

ferjm force-pushed the srcObject branch from b525cac to bc69210 Compare March 26, 2019 17:29

servo-wpt-sync mentioned this pull request Mar 26, 2019

Implement srcObject logic for Blob media providers web-platform-tests/wpt#16088

Merged

CYBAI removed the S-needs-rebase There are merge conflict errors. label Mar 27, 2019

Implement srcObject logic for Blob media providers

d156400

ferjm force-pushed the srcObject branch from bc69210 to d156400 Compare March 27, 2019 06:12

highfive assigned Manishearth and unassigned SimonSapin Mar 27, 2019

highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Apr 3, 2019

highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Apr 3, 2019

highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Apr 3, 2019

bors-servo merged commit d156400 into servo:master Apr 3, 2019

highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 3, 2019

bors-servo mentioned this pull request Apr 3, 2019

Refactoring RequestInit to use a Builder Pattern #22521

Merged

4 tasks

Uh oh!

Conversation

ferjm commented Mar 26, 2019 • edited by SimonSapin Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

highfive commented Mar 26, 2019

Uh oh!

highfive commented Mar 26, 2019

Uh oh!

servo-wpt-sync commented Mar 26, 2019

Uh oh!

CYBAI commented Mar 27, 2019

Uh oh!

CYBAI commented Mar 27, 2019

Uh oh!

servo-wpt-sync commented Mar 27, 2019

Uh oh!

ferjm commented Mar 27, 2019

Uh oh!

bors-servo commented Mar 27, 2019

Uh oh!

ferjm commented Mar 27, 2019

Uh oh!

bors-servo commented Mar 27, 2019

Uh oh!

Manishearth commented Apr 3, 2019

Uh oh!

bors-servo commented Apr 3, 2019

Uh oh!

bors-servo commented Apr 3, 2019

Uh oh!

bors-servo commented Apr 3, 2019

Uh oh!

CYBAI commented Apr 3, 2019

Uh oh!

bors-servo commented Apr 3, 2019

Uh oh!

bors-servo commented Apr 3, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

ferjm commented Mar 26, 2019 •

edited by SimonSapin

Loading