Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to rustc 1.33.0-nightly (c0bbc3927 2019-01-03) #22612

Merged
merged 2 commits into from
Jan 4, 2019
Merged

Upgrade to rustc 1.33.0-nightly (c0bbc3927 2019-01-03) #22612

merged 2 commits into from
Jan 4, 2019

Conversation

SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented Jan 4, 2019 •
edited
Loading

This deals with a breaking change in the language that affect stable code, in the exact opposite way from a previous breaking change from August 2017. See rust-lang/rust#56105 (comment)

This change is Reviewable

@highfive
Copy link

highfive commented Jan 4, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/worker.rs, components/script/dom/stylesheet.rs, components/script/dom/treewalker.rs, components/script/dom/bindings/trace.rs
  • @KiChjang: components/script/dom/worker.rs, components/script/dom/stylesheet.rs, components/script/dom/treewalker.rs, components/script/dom/bindings/trace.rs

@highfive
Copy link

highfive commented Jan 4, 2019

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jan 4, 2019
@jdm
Copy link
Member

jdm commented Jan 4, 2019

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit cf05e37 has been approved by jdm

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jan 4, 2019
@highfive highfive assigned jdm and unassigned Manishearth Jan 4, 2019
@bors-servo
Copy link
Contributor

⌛ Testing commit cf05e37 with merge 7a64588...

bors-servo pushed a commit that referenced this pull request Jan 4, 2019
Auto merge of #22612 - servo:rustup, r=jdm
7a64588 
Upgrade to rustc 1.33.0-nightly (c0bbc3927 2019-01-03)

This deals with a breaking change in the language that affect stable code, in the exact opposite way from a previous breaking change from August 2017. See rust-lang/rust#56105 (comment)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22612)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster
Approved by: jdm
Pushing 7a64588 to master...

@bors-servo bors-servo merged commit cf05e37 into master Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SimonSapin @highfive @jdm @bors-servo @Manishearth