Unregister components while exiting#22474
Merged
bors-servo merged 1 commit intoservo:masterfrom Dec 18, 2018
Merged
Conversation
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @avadacatavra (or someone else) soon. |
|
Heads up! This PR modifies the following files:
|
|
|
highfive
added
the
S-awaiting-review
gterzian
requested changes
Dec 16, 2018
Member
There was a problem hiding this comment.
Looks good so far, thanks!
Could you please add a test-case for this? You could for example do a notify_activity followed by a unregister call, and then assert that after a timeout no alerts have been received on the ipc channel.
gterzian
reviewed
Dec 16, 2018
gterzian
reviewed
Dec 16, 2018
gterzian
reviewed
Dec 17, 2018
csmoe
changed the title
Member
|
Great! Please squash into one commit and then it should be good to go... |
gterzian
added
the
S-needs-squash
KiChjang
removed
the
S-needs-squash
Contributor
|
@bors-servo r=gterzian Thanks! |
Contributor
|
📌 Commit 5600a1d has been approved by |
highfive
added
S-awaiting-merge
Contributor
bors-servo
pushed a commit
that referenced
this pull request
Dec 18, 2018
Unregister components while exiting r=@gterzian <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #22468 (GitHub issue number if applicable) <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22474) <!-- Reviewable:end -->
Contributor
|
💔 Test failed - status-taskcluster |
highfive
added
S-tests-failed
Contributor
|
💣 Failed to start rebuilding: |
Contributor
bors-servo
pushed a commit
that referenced
this pull request
Dec 18, 2018
Unregister components while exiting r=@gterzian <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #22468 (GitHub issue number if applicable) <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22474) <!-- Reviewable:end -->
highfive
added
S-awaiting-merge
Contributor
|
☀️ Test successful - android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster |
highfive
removed
the
S-awaiting-merge
Member
|
@csmoe thank you! |
Contributor
Author
|
@gterzian thank for your patience :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r=@gterzian
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is