Skip to content

Revert #18668 - Add mprotect diagnostics for HashMap crash#18732

Merged
bors-servo merged 1 commit intoservo:masterfrom
bholley:revert_mprotect_diagnostics
Oct 3, 2017
Merged

Revert #18668 - Add mprotect diagnostics for HashMap crash#18732
bors-servo merged 1 commit intoservo:masterfrom
bholley:revert_mprotect_diagnostics

Conversation

@bholley
Copy link
Copy Markdown
Contributor

@bholley bholley commented Oct 3, 2017 •
edited by SimonSapin
Loading

These diagnostics have served their purpose, time to remove them.

https://bugzilla.mozilla.org/show_bug.cgi?id=1403397

This change is Reviewable

@highfive
Copy link
Copy Markdown

highfive commented Oct 3, 2017

Heads up! This PR modifies the following files:

  • @canaltinova: components/style/hash.rs, components/style/gecko/generated/bindings.rs, components/style/selector_parser.rs, components/style/selector_map.rs, components/style/invalidation/element/invalidation_map.rs and 1 more
  • @emilio: components/style/hash.rs, ports/geckolib/glue.rs, ports/geckolib/Cargo.toml, components/style/gecko/generated/bindings.rs, components/style/selector_parser.rs and 4 more

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Oct 3, 2017
@bholley
Copy link
Copy Markdown
Contributor Author

bholley commented Oct 3, 2017

@bors-servo r+ p=5

@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Oct 3, 2017

📌 Commit 0fc5df7 has been approved by bholley

@highfive highfive assigned bholley and unassigned asajeffrey Oct 3, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Oct 3, 2017
@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Oct 3, 2017

⌛ Testing commit 0fc5df7 with merge b75ace1...

bors-servo pushed a commit that referenced this pull request Oct 3, 2017
Auto merge of #18732 - bholley:revert_mprotect_diagnostics, r=bholley
b75ace1 
Revert #18668 - Add mprotect diagnostics for HashMap crash.

These diagnostics have served their purpose, time to remove them.

https://bugzilla.mozilla.org/show_bug.cgi?id=1403397

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18732)
<!-- Reviewable:end -->
@bholley
Copy link
Copy Markdown
Contributor Author

bholley commented Oct 3, 2017

@bors-servo r-

@bholley bholley force-pushed the revert_mprotect_diagnostics branch from 0fc5df7 to d3b9d0d Compare October 3, 2017 17:46
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Oct 3, 2017
@bholley
Copy link
Copy Markdown
Contributor Author

bholley commented Oct 3, 2017

@bors-servo r+

@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Oct 3, 2017

📌 Commit d3b9d0d has been approved by bholley

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Oct 3, 2017
@bholley bholley changed the title Revert #18668 - Add mprotect diagnostics for HashMap crash. Revert #18668 - Add mprotect diagnostics for HashMap crash (except for round-up-to-page behavior). Oct 3, 2017
@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Oct 3, 2017

⌛ Testing commit d3b9d0d with merge 123301b...

bors-servo pushed a commit that referenced this pull request Oct 3, 2017
Auto merge of #18732 - bholley:revert_mprotect_diagnostics, r=bholley
123301b 
Revert #18668 - Add mprotect diagnostics for HashMap crash (except for round-up-to-page behavior).

These diagnostics have served their purpose, time to remove them.

https://bugzilla.mozilla.org/show_bug.cgi?id=1403397

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18732)
<!-- Reviewable:end -->
@bholley bholley force-pushed the revert_mprotect_diagnostics branch from d3b9d0d to af0bed9 Compare October 3, 2017 19:31
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Oct 3, 2017
@bholley
Copy link
Copy Markdown
Contributor Author

bholley commented Oct 3, 2017

@bors-servo r+

@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Oct 3, 2017

📌 Commit af0bed9 has been approved by bholley

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Oct 3, 2017
@bholley
Copy link
Copy Markdown
Contributor Author

bholley commented Oct 3, 2017

@bors-servo r+ force

@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Oct 3, 2017
@bholley
Copy link
Copy Markdown
Contributor Author

bholley commented Oct 3, 2017

@bors-servo retry force

@bholley
Copy link
Copy Markdown
Contributor Author

bholley commented Oct 3, 2017

@bors-servo retry

@bholley
Copy link
Copy Markdown
Contributor Author

bholley commented Oct 3, 2017

@bors-servo r+ force

@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Oct 3, 2017

📌 Commit f457bf6 has been approved by bholley

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Oct 3, 2017
@bholley
Copy link
Copy Markdown
Contributor Author

bholley commented Oct 3, 2017

@bors-servo force

@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Oct 3, 2017

⌛ Testing commit f457bf6 with merge 41ca1b75461e523272b9c51e58d38e41c1e6160a...

@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Oct 3, 2017

💔 Test failed - windows-msvc-dev

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Oct 3, 2017
@bholley bholley force-pushed the revert_mprotect_diagnostics branch from f457bf6 to 15b866d Compare October 3, 2017 19:45
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Oct 3, 2017
@bholley
Copy link
Copy Markdown
Contributor Author

bholley commented Oct 3, 2017

@bors-servo r+ force

@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Oct 3, 2017

📌 Commit 15b866d has been approved by bholley

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Oct 3, 2017
@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Oct 3, 2017

⌛ Testing commit 15b866d with merge 0b69887...

bors-servo pushed a commit that referenced this pull request Oct 3, 2017
Auto merge of #18732 - bholley:revert_mprotect_diagnostics, r=bholley
0b69887 
Revert #18668 - Add mprotect diagnostics for HashMap crash (except for round-up-to-page behavior).

These diagnostics have served their purpose, time to remove them.

https://bugzilla.mozilla.org/show_bug.cgi?id=1403397

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18732)
<!-- Reviewable:end -->
@bors-servo bors-servo mentioned this pull request Oct 3, 2017
Merged
@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Oct 3, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: bholley
Pushing 0b69887 to master...

@bors-servo bors-servo merged commit 15b866d into servo:master Oct 3, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 3, 2017
@bholley bholley changed the title Revert #18668 - Add mprotect diagnostics for HashMap crash (except for round-up-to-page behavior). Revert #18668 - Add mprotect diagnostics for HashMap crash Oct 3, 2017
@upsuper upsuper mentioned this pull request Oct 4, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@bholley bholley

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bholley @highfive @bors-servo @asajeffrey