Skip to content

stylo: use FnvHashMap everywhere, remove default HashMap construction methods#18712

Merged
bors-servo merged 1 commit intoservo:masterfrom
Manishearth:fnv
Oct 4, 2017
Merged

stylo: use FnvHashMap everywhere, remove default HashMap construction methods#18712
bors-servo merged 1 commit intoservo:masterfrom
Manishearth:fnv

Conversation

@Manishearth
Copy link
Copy Markdown
Member

@Manishearth Manishearth commented Oct 2, 2017

r=bholley bug 1385971


This change is Reviewable

@highfive
Copy link
Copy Markdown

highfive commented Oct 2, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/longhand/position.mako.rs, components/style/rule_tree/mod.rs, components/style/dom.rs, components/style/gecko/wrapper.rs
  • @canaltinova: components/style/properties/longhand/position.mako.rs, components/style/rule_tree/mod.rs, components/style/dom.rs, components/style/gecko/wrapper.rs
  • @emilio: components/style/properties/longhand/position.mako.rs, components/style/rule_tree/mod.rs, components/style/dom.rs, components/style/gecko/wrapper.rs

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Oct 2, 2017
@highfive
Copy link
Copy Markdown

highfive commented Oct 2, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!

@Manishearth
Copy link
Copy Markdown
Member Author

@bors-servo r=bholley

@bors-servo
Copy link
Copy Markdown
Contributor

📌 Commit 335f3c0 has been approved by bholley

@highfive highfive assigned bholley and unassigned cbrewster Oct 2, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Oct 2, 2017
@bors-servo
Copy link
Copy Markdown
Contributor

⌛ Testing commit 335f3c0 with merge 56d690d...

bors-servo pushed a commit that referenced this pull request Oct 2, 2017
stylo: use FnvHashMap everywhere, remove default HashMap construction methods

r=bholley bug 1385971
@bors-servo
Copy link
Copy Markdown
Contributor

💔 Test failed - linux-rel-wpt

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Oct 2, 2017
@Manishearth
Copy link
Copy Markdown
Member Author

@bors-servo retry

@bholley
Copy link
Copy Markdown
Contributor

bholley commented Oct 2, 2017

@bors-servo p=2

@bors-servo
Copy link
Copy Markdown
Contributor

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only linux-rel-wpt...

@bors-servo
Copy link
Copy Markdown
Contributor

💥 Test timed out

@Manishearth
Copy link
Copy Markdown
Member Author

@bors-servo retry

@jdm jdm closed this Oct 3, 2017
@jdm jdm reopened this Oct 3, 2017
@mbrubeck
Copy link
Copy Markdown
Contributor

mbrubeck commented Oct 3, 2017

@bors-servo clean r-

@mbrubeck
Copy link
Copy Markdown
Contributor

mbrubeck commented Oct 3, 2017

@bors-servo r+

@bors-servo
Copy link
Copy Markdown
Contributor

📌 Commit 335f3c0 has been approved by mbrubeck

@highfive highfive assigned mbrubeck and unassigned bholley Oct 3, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Oct 3, 2017
@Manishearth
Copy link
Copy Markdown
Member Author

@bors-servo r=bholley clean retry

@bors-servo
Copy link
Copy Markdown
Contributor

📌 Commit 335f3c0 has been approved by bholley

@highfive highfive assigned bholley and unassigned mbrubeck Oct 3, 2017
@bors-servo
Copy link
Copy Markdown
Contributor

🔒 Merge conflict

@bors-servo
Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #18732) made this pull request unmergeable. Please resolve the merge conflicts.

@highfive highfive added S-needs-rebase There are merge conflict errors. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Oct 3, 2017
@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Oct 3, 2017
@Manishearth
Copy link
Copy Markdown
Member Author

@bors-servo r=bholley

@bors-servo
Copy link
Copy Markdown
Contributor

📌 Commit 8bce37e has been approved by bholley

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. S-needs-rebase There are merge conflict errors. labels Oct 3, 2017
@bors-servo
Copy link
Copy Markdown
Contributor

⌛ Testing commit 8bce37e with merge e96b023...

bors-servo pushed a commit that referenced this pull request Oct 3, 2017
stylo: use FnvHashMap everywhere, remove default HashMap construction methods

r=bholley bug 1385971

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18712)
<!-- Reviewable:end -->
@bors-servo
Copy link
Copy Markdown
Contributor

💔 Test failed - windows-msvc-dev

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Oct 3, 2017
@Manishearth
Copy link
Copy Markdown
Member Author

@bors-servo retry

@bors-servo
Copy link
Copy Markdown
Contributor

⌛ Testing commit 8bce37e with merge 89724c6...

bors-servo pushed a commit that referenced this pull request Oct 3, 2017
stylo: use FnvHashMap everywhere, remove default HashMap construction methods

r=bholley bug 1385971

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18712)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Oct 3, 2017
@bors-servo
Copy link
Copy Markdown
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: bholley
Pushing 89724c6 to master...

@bors-servo bors-servo merged commit 8bce37e into servo:master Oct 4, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 4, 2017
@Manishearth Manishearth deleted the fnv branch October 4, 2017 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants