Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @asajeffrey (or someone else) soon.

Heads up! This PR modifies the following files:

• @bholley: components/style/gecko_bindings/sugar/ns_timing_function.rs, components/style/properties/gecko.mako.rs, components/style/animation.rs, components/style/properties/helpers/animated_properties.mako.rs, components/style/properties/properties.mako.rs and 7 more
• @jgraham: components/webdriver_server/Cargo.toml
• @wafflespeanut: python/tidy/servo_tidy_tests/rust_tidy.rs
• @emilio: components/style/gecko_bindings/sugar/ns_timing_function.rs, components/style/properties/gecko.mako.rs, components/style/animation.rs, components/layout/multicol.rs, components/layout/list_item.rs and 21 more
• @fitzgen: components/script/dom/htmlcanvaselement.rs, components/script/timers.rs, components/script/dom/imagedata.rs, components/script_traits/script_msg.rs, components/script_traits/script_msg.rs and 25 more
• @KiChjang: components/script/dom/htmlcanvaselement.rs, components/script/timers.rs, components/script/dom/imagedata.rs, components/script_traits/script_msg.rs, components/script_traits/script_msg.rs and 25 more
• @asajeffrey: components/constellation/browsingcontext.rs, components/constellation/constellation.rs, components/webdriver_server/Cargo.toml, components/constellation/pipeline.rs, components/constellation/Cargo.toml

Warning

• These commits modify unsafe code. Please review it carefully!

This requires webrender the equivalent WebRender and rust-azure changes to be merged/published, in order to build (I did get it to work locally), but the review is going to be a lot of work so I am submitting this early for people to start looking at it. This pull request is enormous, and I am truly sorry for this.
We made some major changes to euclid, in particular the separation of points and vector types. See servo/euclid#159.

cc @nox

☔ The latest upstream changes (presumably #17186) made this pull request unmergeable. Please resolve the merge conflicts.

Gosh, you're not kidding about this being a big change!

Are most of the changes to euclid naming? Would it be possible/useful to publish an intermediate version of euclid with both naming schemes?

The biggest change is the separation between vector and points. The rest of the diff is trivial changes like renaming Matrix2D/4D into Transform2D/3D and cleaning up the namespaces (use euclid::rect::Rect; becomes use euclid::Rect).
There is also two commits about SVG and animations that are not actually from this PR but that appear in the diff. After I have rebased this, they will disappear from the diff.

Once I have rebased this patch though, most of the non-trivial changes won't be in the diff, and if you want I can roll back the the Matrix/Transform renaming (this specific part doesn't occupy much room in the diff though) since I left an alias for the old name in euclid marked as deprecated, so it can be postponed if servo build does not deny warnings.

For the other changes, I am sorry but I spent way too much time getting this euclid bump into all of the servo crates outside the main repo, getting reviews an getting things published on crates in the correct order. I ended up doing mostly that for more than a week and I won't do it again. Had I known how much work this would be, I would not have made these changes to euclid.

I rebased and added a commit that reverts the matrix/transform renaming part (at the cost of introducing deprecation warnings). The total diff is a lot less scary to look at now.
Let me know if you prefer things squashed as is and move the matrix/transform stuff to a separate PR or if you want it in this one.

I kept another commit separated: the one that turns BaseFlow::stacking_relative_position into a vector instead of a point. For this one I wasn't 100% sure whether it made most sense as a vector or a point (short of knowing the layout code well enough), so it is still in its own commit which can be removed easily if need be.

Things still don't build on CI because I still need the equivalent webrender PR to be merged, but it works locally.

☔ The latest upstream changes (presumably #16752) made this pull request unmergeable. Please resolve the merge conflicts.

Looks good to me.

Reviewed 39 of 87 files at r1, 41 of 51 files at r4, 9 of 9 files at r5.
Review status: all files reviewed at latest revision, 3 unresolved discussions.

components/canvas/canvas_paint_thread.rs, line 651 at r5 (raw file):

        // Step 6.
        let dest_rect = dirty_rect.translate(&offset.to_vector()).to_i32();

Should offset be a vector to start with?

components/script/dom/document.rs, line 869 at r5 (raw file):

                let rect = iframe.upcast::<Element>().GetBoundingClientRect();
                let child_origin = Point2D::new(rect.X() as f32, rect.Y() as f32);
                let child_point = client_point - child_origin.to_vector();

Could child_origin be a vector to start with? (Here and 3 others in this file.)

Comments from Reviewable

The review comments have been addressed, should we land this now?

Thank you!

@bors-servo r+

Reviewed 3 of 13 files at r6, 9 of 9 files at r7, 1 of 10 files at r8, 9 of 9 files at r9.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

📌 Commit 87e6a6c has been approved by SimonSapin

⌛ Testing commit 87e6a6c with merge 4e25084...

💔 Test failed - linux-dev

@bors-servo r+

Reviewed 15 of 24 files at r10, 9 of 9 files at r11.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

📌 Commit 997608f has been approved by SimonSapin

⌛ Testing commit 997608f with merge 18653f6...

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: SimonSapin
Pushing 18653f6 to master...