Added compiletest to verify TrustedPromise does not implement Clone#15146
Merged
bors-servo merged 1 commit intoservo:masterfrom Jan 22, 2017
Merged
Conversation
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @SimonSapin (or someone else) soon. |
highfive
added
the
S-awaiting-review
|
|
Member
|
I have no feedback that needs addressing; this looks great! @bors-servo: r+ |
Contributor
|
📌 Commit 072ca3b has been approved by |
highfive
added
S-awaiting-merge
Contributor
bors-servo
pushed a commit
that referenced
this pull request
Jan 22, 2017
Added compiletest to verify TrustedPromise does not implement Clone As per issue: #14500 I have added a test to ensure that TrustedPromise does not implement Clone. This is my first PR to the project, so feedback in terms of both code and the actual PR would be very welcome. Thanks, Verlet64 --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #14500 - [x] There are tests for these changes <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15146) <!-- Reviewable:end -->
Contributor
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per issue: #14500
I have added a test to ensure that TrustedPromise does not implement Clone.
This is my first PR to the project, so feedback in terms of both code and the actual PR would be very welcome.
Thanks,
Verlet64
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is