Documents now fully deactivate when a freeze message is sent#15016
Merged
bors-servo merged 1 commit intoservo:masterfrom Jan 13, 2017
0xRampey:doc-deactivate
Merged
Documents now fully deactivate when a freeze message is sent#15016bors-servo merged 1 commit intoservo:masterfrom 0xRampey:doc-deactivate
bors-servo merged 1 commit intoservo:masterfrom
0xRampey:doc-deactivate
Conversation
|
|
highfive
added
the
S-awaiting-review
Contributor
|
@bors-servo r+ |
Contributor
|
📌 Commit 584f72d has been approved by |
highfive
added
S-awaiting-merge
Collaborator
|
I'm traveling all weekend so someone else should grab this if it can't wait until Monday. |
Collaborator
|
Or just get it done while I'm logging in from my phone. That works too :) |
Contributor
Author
|
You're welcome. :) |
Contributor
bors-servo
pushed a commit
that referenced
this pull request
Jan 13, 2017
Documents now fully deactivate when a freeze message is sent <!-- Please describe your changes on the following line: --> Documents now fully deactivate when a freeze message is sent --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #14906 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because minimal changes. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15016) <!-- Reviewable:end -->
Contributor
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents now fully deactivate when a freeze message is sent
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is