Remove the util crate by asajeffrey · Pull Request #14592 · servo/servo

asajeffrey · 2016-12-14T20:52:58Z

This PR removes the util crate.

Replaced the spawn_named and clamp functions by appropriate uses of std::thread::Builder::spawn, std::cmp::min and std::cmp::max.
Moved opts, prefs and resource_files into a new config crate.
Moved remutex and geometry into their own crates.

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes do not require tests because they are refactorings

This change is

highfive · 2016-12-14T20:53:02Z

Heads up! This PR modifies the following files:

@bholley: components/style/stylesheets.rs, components/style/properties/properties.mako.rs, components/style/parallel.rs, components/style/Cargo.toml, components/style/lib.rs, components/style/traversal.rs, components/style/matching.rs
@jgraham: components/webdriver_server/Cargo.toml, components/webdriver_server/lib.rs
@KiChjang: components/script/dom/navigatorinfo.rs, components/script/timers.rs, components/net/http_loader.rs, components/net/storage_thread.rs, components/script/dom/create.rs, components/script/Cargo.toml, components/script/script_thread.rs, components/net/resource_thread.rs, components/script/serviceworker_manager.rs, components/script/dom/htmlanchorelement.rs, components/net/lib.rs, components/net/hsts.rs, components/script/dom/servoparser/mod.rs, components/script/dom/testbinding.rs, components/script/dom/xmlhttprequest.rs, components/net/image_cache_thread.rs, components/script/dom/bindings/conversions.rs, components/net/filemanager_thread.rs, components/script/dom/bindings/guard.rs, components/script/dom/userscripts.rs, components/script/dom/htmlmetaelement.rs, components/script/dom/filereader.rs, components/script/dom/mouseevent.rs, components/script/dom/window.rs, components/script/dom/document.rs, components/net_traits/lib.rs, components/net_traits/lib.rs, components/script/dom/bindings/codegen/CodegenRust.py, components/net/Cargo.toml, components/net/chrome_loader.rs, components/net/content_blocker.rs, components/net_traits/pub_domains.rs, components/net_traits/pub_domains.rs, components/script/dom/characterdata.rs, components/net_traits/Cargo.toml, components/net_traits/Cargo.toml, components/script/lib.rs, components/net/connector.rs, components/script/dom/dedicatedworkerglobalscope.rs, components/net/websocket_loader.rs, components/script/script_runtime.rs, components/script/dom/htmliframeelement.rs, components/script/dom/serviceworkerglobalscope.rs
@fitzgen: components/script/dom/navigatorinfo.rs, components/profile_traits/Cargo.toml, components/profile_traits/Cargo.toml, components/script/timers.rs, components/debugger/Cargo.toml, components/script/dom/create.rs, components/devtools/actors/timeline.rs, components/script/Cargo.toml, components/profile_traits/lib.rs, components/profile_traits/lib.rs, components/script/script_thread.rs, components/script/serviceworker_manager.rs, components/script/dom/htmlanchorelement.rs, components/debugger/lib.rs, components/script/dom/servoparser/mod.rs, components/profile/Cargo.toml, components/devtools/Cargo.toml, components/script/dom/testbinding.rs, components/script/dom/xmlhttprequest.rs, components/devtools/lib.rs, components/profile/heartbeats.rs, components/profile/mem.rs, components/script/dom/bindings/conversions.rs, components/script/dom/bindings/guard.rs, components/script/dom/userscripts.rs, components/script/dom/htmlmetaelement.rs, components/script/dom/filereader.rs, components/script/dom/mouseevent.rs, components/script/dom/window.rs, components/script/dom/document.rs, components/script/dom/bindings/codegen/CodegenRust.py, components/profile/time.rs, components/profile_traits/time.rs, components/profile_traits/time.rs, components/profile/lib.rs, components/script/dom/characterdata.rs, components/script/lib.rs, components/script/dom/dedicatedworkerglobalscope.rs, components/script/script_runtime.rs, components/script/dom/htmliframeelement.rs, components/script/dom/serviceworkerglobalscope.rs
@emilio: components/style/stylesheets.rs, components/style/properties/properties.mako.rs, components/canvas/webgl_paint_thread.rs, components/layout/traversal.rs, components/layout/sequential.rs, components/style/parallel.rs, components/style/Cargo.toml, components/style/lib.rs, components/layout/parallel.rs, components/layout/context.rs, components/layout/construct.rs, components/layout/display_list_builder.rs, components/layout/block.rs, components/style/traversal.rs, components/style/matching.rs, components/layout/Cargo.toml, components/layout/lib.rs

highfive · 2016-12-14T20:53:03Z

Warning

These commits modify unsafe code. Please review it carefully!

mbrubeck

r=mbrubeck with some nits. (Could be fixed by just squashing into a single commit.)

mbrubeck · 2016-12-14T21:05:12Z

components/geometry/Cargo.toml

@@ -0,0 +1,19 @@
+[package]


Nit: This addition is in the wrong commit.

mbrubeck · 2016-12-14T21:05:23Z

components/remutex/Cargo.toml

@@ -0,0 +1,14 @@
+[package]


Nit: This addition is in the wrong commit.

mbrubeck · 2016-12-14T21:05:32Z

tests/unit/remutex/Cargo.toml

@@ -0,0 +1,14 @@
+[package]


Nit: This addition is in the wrong commit.

mbrubeck · 2016-12-14T21:06:59Z

tests/unit/util/thread.rs

@@ -1,13 +0,0 @@
-/* This Source Code Form is subject to the terms of the Mozilla Public


This deletion is in the wrong commit.

asajeffrey · 2016-12-14T21:12:43Z

Squashed. @bors-servo: r=mbrubeck

bors-servo · 2016-12-14T21:12:46Z

📌 Commit facca14 has been approved by mbrubeck

KiChjang · 2016-12-14T21:17:52Z

@bors-servo p=10

bors-servo · 2016-12-14T21:28:35Z

⌛ Testing commit facca14 with merge 70219ae...

Remove the util crate  This PR removes the `util` crate. * Replaced the `spawn_named` and `clamp` functions by appropriate uses of `std::thread::Builder::spawn`, `std::cmp::min` and `std::cmp::max`. * Moved `opts`, `prefs` and `resource_files` into a new `config` crate. * Moved `remutex` and `geometry` into their own crates. ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because they are refactorings   --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14592)

bors-servo · 2016-12-14T21:53:50Z

💔 Test failed - linux-dev

KiChjang · 2016-12-14T22:22:01Z

Unit tests imports need to be updated, I presume?

asajeffrey · 2016-12-14T22:28:26Z

@KiChjang indeed, doing that right now. Ditto cef.

asajeffrey · 2016-12-14T22:41:29Z

Updated unit tests and cef port. @bors-servo r=mbrubreck p=10

bors-servo · 2016-12-14T22:41:30Z

📌 Commit caacb9b has been approved by mbrubreck

bors-servo · 2016-12-14T23:13:55Z

⌛ Testing commit caacb9b with merge e9a1129...

Remove the util crate  This PR removes the `util` crate. * Replaced the `spawn_named` and `clamp` functions by appropriate uses of `std::thread::Builder::spawn`, `std::cmp::min` and `std::cmp::max`. * Moved `opts`, `prefs` and `resource_files` into a new `config` crate. * Moved `remutex` and `geometry` into their own crates. ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because they are refactorings   --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14592)

bors-servo · 2016-12-14T23:29:42Z

💔 Test failed - linux-dev

KiChjang · 2016-12-14T23:40:05Z

error: unused import
  --> /home/servo/buildbot/slave/linux-dev/build/target/geckolib/debug/build/style-584c140631e9c02b/out/properties.rs:31:5
   |
31 | use servo_config::prefs::PREFS;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^
/home/servo/buildbot/slave/linux-dev/build/components/style/lib.rs:155:5: 155:58 note: in this expansion of include!
   |
note: lint level defined here
  --> /home/servo/buildbot/slave/linux-dev/build/components/style/lib.rs:30:9
   |
30 | #![deny(warnings)]
   |         ^^^^^^^^

asajeffrey · 2016-12-14T23:43:37Z

Oh bah humbug, geckolib.

asajeffrey · 2016-12-15T00:07:19Z

Fixed geckolib @bors-servo r=mbrubeck

bors-servo · 2016-12-15T00:07:20Z

📌 Commit 9be4fd5 has been approved by mbrubeck

bors-servo · 2016-12-15T00:48:43Z

⌛ Testing commit 9be4fd5 with merge 4eb6538...

Remove the util crate  This PR removes the `util` crate. * Replaced the `spawn_named` and `clamp` functions by appropriate uses of `std::thread::Builder::spawn`, `std::cmp::min` and `std::cmp::max`. * Moved `opts`, `prefs` and `resource_files` into a new `config` crate. * Moved `remutex` and `geometry` into their own crates. ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because they are refactorings   --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14592)

bors-servo · 2016-12-15T01:40:51Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev

asajeffrey added the I-refactor No impact; the issue is one of maintainability or tidiness. Proposed solution requires refactoring. label Dec 14, 2016

highfive assigned mbrubeck Dec 14, 2016

highfive added the S-awaiting-review There is new code that needs to be reviewed. label Dec 14, 2016

asajeffrey force-pushed the util-goodbye branch from d629e85 to 452beb1 Compare December 14, 2016 20:56

mbrubeck suggested changes Dec 14, 2016

View reviewed changes

asajeffrey force-pushed the util-goodbye branch from 2cada86 to facca14 Compare December 14, 2016 21:12

highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Dec 14, 2016

highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Dec 14, 2016

asajeffrey force-pushed the util-goodbye branch from facca14 to caacb9b Compare December 14, 2016 22:40

highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Dec 14, 2016

highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Dec 14, 2016

highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Dec 14, 2016

Removed util.

9be4fd5

asajeffrey force-pushed the util-goodbye branch from caacb9b to 9be4fd5 Compare December 15, 2016 00:04

highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Dec 15, 2016

highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Dec 15, 2016

bors-servo mentioned this pull request Dec 15, 2016

Update WR + gleam (nested clip stack, scroll locations). #14412

Merged

bors-servo merged commit 9be4fd5 into servo:master Dec 15, 2016

highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Dec 15, 2016

This was referenced Dec 15, 2016

An in-memory RNG that shares its file descriptor. #14351

Merged

style: Add a simple rule-tree benchmarks. #14485

Merged

Add preference toggling touch events. #14534

Closed

Implement discarding Document objects to reclaim space. #14312

Merged

		@@ -1,13 +0,0 @@
		/* This Source Code Form is subject to the terms of the Mozilla Public

Uh oh!

Conversation

asajeffrey commented Dec 14, 2016 • edited by larsbergstrom Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

highfive commented Dec 14, 2016

Uh oh!

highfive commented Dec 14, 2016

Uh oh!

mbrubeck left a comment

Choose a reason for hiding this comment

Uh oh!

mbrubeck Dec 14, 2016

Choose a reason for hiding this comment

Uh oh!

mbrubeck Dec 14, 2016

Choose a reason for hiding this comment

Uh oh!

mbrubeck Dec 14, 2016

Choose a reason for hiding this comment

Uh oh!

mbrubeck Dec 14, 2016

Choose a reason for hiding this comment

Uh oh!

asajeffrey commented Dec 14, 2016

Uh oh!

bors-servo commented Dec 14, 2016

Uh oh!

KiChjang commented Dec 14, 2016

Uh oh!

bors-servo commented Dec 14, 2016

Uh oh!

bors-servo commented Dec 14, 2016

Uh oh!

KiChjang commented Dec 14, 2016

Uh oh!

asajeffrey commented Dec 14, 2016

Uh oh!

asajeffrey commented Dec 14, 2016

Uh oh!

bors-servo commented Dec 14, 2016

Uh oh!

bors-servo commented Dec 14, 2016

Uh oh!

bors-servo commented Dec 14, 2016

Uh oh!

KiChjang commented Dec 14, 2016

Uh oh!

asajeffrey commented Dec 14, 2016

Uh oh!

asajeffrey commented Dec 15, 2016

Uh oh!

bors-servo commented Dec 15, 2016

Uh oh!

bors-servo commented Dec 15, 2016

Uh oh!

bors-servo commented Dec 15, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

asajeffrey commented Dec 14, 2016 •

edited by larsbergstrom

Loading