Skip to content

Improve safety or our tracing architecture#14557

Merged
bors-servo merged 4 commits intoservo:masterfrom
nox:trace
Dec 13, 2016
Merged

Improve safety or our tracing architecture#14557
bors-servo merged 4 commits intoservo:masterfrom
nox:trace

Conversation

@nox
Copy link
Copy Markdown
Contributor

@nox nox commented Dec 12, 2016 •
edited by larsbergstrom
Loading

This change is Reviewable

nox added 4 commits December 12, 2016 10:31
@nox
Clean up ROOTED_TRACEABLES
62fb207
@nox
Use trait objects in RootedTraceableSet
f7d53b7
@nox
Remove HeapGCValue
1327ebd 
It could be used to have mutable JSVal fields without GC barriers.
With the removal of that trait, MutHeap and MutNullableHeap can respectively
be replaced by MutJS and MutNullableJS.
@nox
Properly root the running animation list in a RootedVec
26ab0f8
@highfive
Copy link
Copy Markdown

highfive commented Dec 12, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/request.rs, components/script/dom/nodeiterator.rs, components/script/dom/navigator.rs, components/script/dom/htmlcollection.rs, components/script/dom/workerglobalscope.rs, components/script/dom/mouseevent.rs, components/script/dom/treewalker.rs, components/script/dom/range.rs, components/script/dom/client.rs, components/script/dom/focusevent.rs, components/script/dom/filereader.rs, components/script/dom/htmlselectelement.rs, components/script/dom/csskeyframesrule.rs, components/script/dom/htmlinputelement.rs, components/script/dom/window.rs, components/script/dom/bluetoothdevice.rs, components/script/dom/uievent.rs, components/script/dom/bluetoothremotegattserver.rs, components/script/dom/document.rs, components/script/dom/htmllinkelement.rs, components/script/dom/cssmediarule.rs, components/script/dom/cssgroupingrule.rs, components/script/dom/webglrenderingcontext.rs, components/script/dom/browsingcontext.rs, components/script/dom/cssrulelist.rs, components/script/dom/htmltablerowelement.rs, components/script/dom/htmlmediaelement.rs, components/script/dom/mod.rs, components/script/dom/webglprogram.rs, components/script/dom/htmltemplateelement.rs, components/script/dom/macros.rs, components/script/dom/webglframebuffer.rs, components/script/dom/htmlstyleelement.rs, components/script/dom/bluetoothremotegattservice.rs, components/script/dom/url.rs, components/script/dom/touchevent.rs, components/script/dom/touch.rs, components/script/dom/bluetooth.rs, components/script/dom/bluetoothremotegattdescriptor.rs, components/script/script_thread.rs, components/script/dom/bindings/js.rs, components/script/dom/bluetoothremotegattcharacteristic.rs, components/script/dom/response.rs, components/script/dom/xmlhttprequest.rs, components/script/dom/htmliframeelement.rs, components/script/dom/htmlareaelement.rs, components/script/dom/attr.rs, components/script/dom/htmlcanvaselement.rs, components/script/dom/htmlmetaelement.rs, components/script/dom/globalscope.rs, components/script/dom/htmlelement.rs, components/script/dom/event.rs, components/script/dom/htmlanchorelement.rs, components/script/dom/htmlformelement.rs, components/script/dom/node.rs, components/script/dom/servoparser/xml.rs, components/script/dom/bindings/trace.rs, components/script/dom/element.rs, components/script/dom/nodelist.rs, components/script/dom/serviceworkercontainer.rs, components/script/dom/storageevent.rs, components/script/dom/cssstylesheet.rs, components/script/dom/htmltableelement.rs
  • @fitzgen: components/script/dom/request.rs, components/script/dom/nodeiterator.rs, components/script/dom/navigator.rs, components/script/dom/htmlcollection.rs, components/script/dom/workerglobalscope.rs, components/script/dom/mouseevent.rs, components/script/dom/treewalker.rs, components/script/dom/range.rs, components/script/dom/client.rs, components/script/dom/focusevent.rs, components/script/dom/filereader.rs, components/script/dom/htmlselectelement.rs, components/script/dom/csskeyframesrule.rs, components/script/dom/htmlinputelement.rs, components/script/dom/window.rs, components/script/dom/bluetoothdevice.rs, components/script/dom/uievent.rs, components/script/dom/bluetoothremotegattserver.rs, components/script/dom/document.rs, components/script/dom/htmllinkelement.rs, components/script/dom/cssmediarule.rs, components/script/dom/cssgroupingrule.rs, components/script/dom/webglrenderingcontext.rs, components/script/dom/browsingcontext.rs, components/script/dom/cssrulelist.rs, components/script/dom/htmltablerowelement.rs, components/script/dom/htmlmediaelement.rs, components/script/dom/mod.rs, components/script/dom/webglprogram.rs, components/script/dom/htmltemplateelement.rs, components/script/dom/macros.rs, components/script/dom/webglframebuffer.rs, components/script/dom/htmlstyleelement.rs, components/script/dom/bluetoothremotegattservice.rs, components/script/dom/url.rs, components/script/dom/touchevent.rs, components/script/dom/touch.rs, components/script/dom/bluetooth.rs, components/script/dom/bluetoothremotegattdescriptor.rs, components/script/script_thread.rs, components/script/dom/bindings/js.rs, components/script/dom/bluetoothremotegattcharacteristic.rs, components/script/dom/response.rs, components/script/dom/xmlhttprequest.rs, components/script/dom/htmliframeelement.rs, components/script/dom/htmlareaelement.rs, components/script/dom/attr.rs, components/script/dom/htmlcanvaselement.rs, components/script/dom/htmlmetaelement.rs, components/script/dom/globalscope.rs, components/script/dom/htmlelement.rs, components/script/dom/event.rs, components/script/dom/htmlanchorelement.rs, components/script/dom/htmlformelement.rs, components/script/dom/node.rs, components/script/dom/servoparser/xml.rs, components/script/dom/bindings/trace.rs, components/script/dom/element.rs, components/script/dom/nodelist.rs, components/script/dom/serviceworkercontainer.rs, components/script/dom/storageevent.rs, components/script/dom/cssstylesheet.rs, components/script/dom/htmltableelement.rs
  • @emilio: components/script/dom/webglrenderingcontext.rs, components/script/dom/webglprogram.rs, components/script/dom/webglframebuffer.rs

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Dec 12, 2016
@highfive
Copy link
Copy Markdown

highfive commented Dec 12, 2016

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify script code, but no tests are modified. Please consider adding a test!

@nox
Copy link
Copy Markdown
Contributor Author

nox commented Dec 12, 2016

r? @jdm

@highfive highfive assigned jdm and unassigned pcwalton Dec 12, 2016
@nox
Copy link
Copy Markdown
Contributor Author

nox commented Dec 12, 2016

@bors-servo p=1

@jdm
Copy link
Copy Markdown
Member

jdm commented Dec 13, 2016

@bors-servo: r+

@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Dec 13, 2016

📌 Commit 26ab0f8 has been approved by jdm

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Dec 13, 2016
@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Dec 13, 2016

⌛ Testing commit 26ab0f8 with merge 242c018...

bors-servo pushed a commit that referenced this pull request Dec 13, 2016
Auto merge of #14557 - nox:trace, r=jdm
242c018 
Improve safety or our tracing architecture

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14557)
<!-- Reviewable:end -->
@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Dec 13, 2016

💔 Test failed - mac-rel-wpt2

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Dec 13, 2016
@jdm
Copy link
Copy Markdown
Member

jdm commented Dec 13, 2016

@bors-servo: retry

  • network failure

@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Dec 13, 2016

⌛ Testing commit 26ab0f8 with merge 87f7b29...

bors-servo pushed a commit that referenced this pull request Dec 13, 2016
Auto merge of #14557 - nox:trace, r=jdm
87f7b29 
Improve safety or our tracing architecture

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14557)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Dec 13, 2016
@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Dec 13, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev

@bors-servo bors-servo merged commit 26ab0f8 into servo:master Dec 13, 2016
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Dec 13, 2016
@bors-servo bors-servo mentioned this pull request Dec 13, 2016
Merged
This was referenced Dec 13, 2016
Merged
Merged
@nox nox deleted the trace branch December 13, 2016 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jdm jdm

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nox @highfive @jdm @bors-servo @pcwalton