Skip to content

Remove Constellation::child_processes.#14536

Merged
bors-servo merged 2 commits intoservo:masterfrom
frewsxcv:constellation-child-processes
Dec 14, 2016
Merged

Remove Constellation::child_processes.#14536
bors-servo merged 2 commits intoservo:masterfrom
frewsxcv:constellation-child-processes

Conversation

@frewsxcv
Copy link
Copy Markdown
Contributor

@frewsxcv frewsxcv commented Dec 9, 2016 •
edited by larsbergstrom
Loading

Fixes #11459.

This change is Reviewable

@highfive
Copy link
Copy Markdown

highfive commented Dec 9, 2016

Heads up! This PR modifies the following files:

  • @asajeffrey: components/constellation/pipeline.rs, components/constellation/constellation.rs

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Dec 9, 2016
@frewsxcv
Copy link
Copy Markdown
Contributor Author

frewsxcv commented Dec 9, 2016

cc @Ms2ger @asajeffrey

@Ms2ger
Copy link
Copy Markdown
Contributor

Ms2ger commented Dec 9, 2016

Do we need the ChildProcess type at all?

@KiChjang
Copy link
Copy Markdown
Contributor

KiChjang commented Dec 9, 2016

cc @pcwalton

@jdm
Copy link
Copy Markdown
Member

jdm commented Dec 14, 2016

@bors-servo: r+

@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Dec 14, 2016

📌 Commit c11b333 has been approved by jdm

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Dec 14, 2016
@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Dec 14, 2016

⌛ Testing commit c11b333 with merge 01b6ad5...

bors-servo pushed a commit that referenced this pull request Dec 14, 2016
Auto merge of #14536 - frewsxcv:constellation-child-processes, r=jdm
01b6ad5 
Remove `Constellation::child_processes`.

Fixes #11459.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14536)
<!-- Reviewable:end -->
@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Dec 14, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev

@bors-servo bors-servo merged commit c11b333 into servo:master Dec 14, 2016
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Dec 14, 2016
This was referenced Dec 14, 2016
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jdm jdm

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@frewsxcv @highfive @Ms2ger @KiChjang @jdm @bors-servo