Skip to content

Rename Reflectable to DomObject.#14495

Merged
bors-servo merged 1 commit intoservo:masterfrom
frewsxcv:reflectable-domobject
Dec 8, 2016
Merged

Rename Reflectable to DomObject.#14495
bors-servo merged 1 commit intoservo:masterfrom
frewsxcv:reflectable-domobject

Conversation

@frewsxcv
Copy link
Copy Markdown
Contributor

@frewsxcv frewsxcv commented Dec 8, 2016 •
edited by larsbergstrom
Loading

Fixes #8473.

This change is Reviewable

@highfive
Copy link
Copy Markdown

highfive commented Dec 8, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/request.rs, components/script/dom/htmlformcontrolscollection.rs, components/script/dom/navigator.rs, components/script/serviceworkerjob.rs, components/script/dom/htmlformelement.rs, components/script/dom/htmlscriptelement.rs, components/script/dom/filereader.rs, components/script/dom/bindings/inheritance.rs, components/script/dom/csskeyframesrule.rs, components/script/dom/window.rs, components/script/dom/blob.rs, components/script/dom/abstractworker.rs, components/script/devtools.rs, components/script/dom/bluetoothremotegattserver.rs, components/script/dom/document.rs, components/script/dom/abstractworkerglobalscope.rs, components/script/dom/bindings/refcounted.rs, components/script/dom/eventtarget.rs, components/script/dom/cssgroupingrule.rs, components/script/dom/webglrenderingcontext.rs, components/script/dom/browsingcontext.rs, components/script/dom/bindings/callback.rs, components/script/dom/cssrulelist.rs, components/script/dom/bluetoothdevice.rs, components/script/dom/eventdispatcher.rs, components/script/mem.rs, components/script/dom/htmlmediaelement.rs, components/script/docs/JS-Servos-only-GC.md, components/script/fetch.rs, components/script/dom/bindings/iterable.rs, components/script/dom/domquad.rs, components/script/dom/testrunner.rs, components/script/dom/workerglobalscope.rs, components/script/dom/bindings/codegen/CodegenRust.py, components/script/dom/worker.rs, components/script/dom/testbinding.rs, components/script/dom/websocket.rs, components/script/dom/htmllinkelement.rs, components/script/dom/bindings/weakref.rs, components/script/dom/serviceworker.rs, components/script/dom/bluetoothremotegattservice.rs, components/script/dom/dedicatedworkerglobalscope.rs, components/script/dom/url.rs, components/script/dom/cssmediarule.rs, components/script/dom/bluetooth.rs, components/script/dom/bluetoothremotegattdescriptor.rs, components/script/script_thread.rs, components/script/dom/bindings/js.rs, components/script/dom/bluetoothremotegattcharacteristic.rs, components/script/dom/response.rs, components/script/dom/promise.rs, components/script/dom/xmlhttprequest.rs, components/script/timers.rs, components/script/dom/htmliframeelement.rs, components/script/dom/storage.rs, components/script/dom/webglprogram.rs, components/script/dom/dommatrixreadonly.rs, components/script/dom/mod.rs, components/script/dom/globalscope.rs, components/script/dom/canvasrenderingcontext2d.rs, components/script/body.rs, components/script/dom/bindings/reflector.rs, components/script/dom/bindings/conversions.rs, components/script/dom/node.rs, components/script/dom/serviceworkerglobalscope.rs, components/script/dom/bindings/trace.rs, components/script/dom/eventsource.rs, components/script/dom/serviceworkercontainer.rs, components/script/dom/cssstylesheet.rs, components/script/dom/formdata.rs
  • @fitzgen: components/script/dom/request.rs, components/script/dom/htmlformcontrolscollection.rs, components/script/dom/navigator.rs, components/script/serviceworkerjob.rs, components/script/dom/htmlformelement.rs, components/script/dom/htmlscriptelement.rs, components/script/dom/filereader.rs, components/script/dom/bindings/inheritance.rs, components/script/dom/csskeyframesrule.rs, components/script/dom/window.rs, components/script/dom/blob.rs, components/script/dom/abstractworker.rs, components/script/devtools.rs, components/script/dom/bluetoothremotegattserver.rs, components/script/dom/document.rs, components/script/dom/abstractworkerglobalscope.rs, components/script/dom/bindings/refcounted.rs, components/script/dom/eventtarget.rs, components/script/dom/cssgroupingrule.rs, components/script/dom/webglrenderingcontext.rs, components/script/dom/browsingcontext.rs, components/script/dom/bindings/callback.rs, components/script/dom/cssrulelist.rs, components/script/dom/bluetoothdevice.rs, components/script/dom/eventdispatcher.rs, components/script/mem.rs, components/script/dom/htmlmediaelement.rs, components/script/docs/JS-Servos-only-GC.md, components/script/fetch.rs, components/script/dom/bindings/iterable.rs, components/script/dom/domquad.rs, components/script/dom/testrunner.rs, components/script/dom/workerglobalscope.rs, components/script/dom/bindings/codegen/CodegenRust.py, components/script/dom/worker.rs, components/script/dom/testbinding.rs, components/script/dom/websocket.rs, components/script/dom/htmllinkelement.rs, components/script/dom/bindings/weakref.rs, components/script/dom/serviceworker.rs, components/script/dom/bluetoothremotegattservice.rs, components/script/dom/dedicatedworkerglobalscope.rs, components/script/dom/url.rs, components/script/dom/cssmediarule.rs, components/script/dom/bluetooth.rs, components/script/dom/bluetoothremotegattdescriptor.rs, components/script/script_thread.rs, components/script/dom/bindings/js.rs, components/script/dom/bluetoothremotegattcharacteristic.rs, components/script/dom/response.rs, components/script/dom/promise.rs, components/script/dom/xmlhttprequest.rs, components/script/timers.rs, components/script/dom/htmliframeelement.rs, components/script/dom/storage.rs, components/script/dom/webglprogram.rs, components/script/dom/dommatrixreadonly.rs, components/script/dom/mod.rs, components/script/dom/globalscope.rs, components/script/dom/canvasrenderingcontext2d.rs, components/script/body.rs, components/script/dom/bindings/reflector.rs, components/script/dom/bindings/conversions.rs, components/script/dom/node.rs, components/script/dom/serviceworkerglobalscope.rs, components/script/dom/bindings/trace.rs, components/script/dom/eventsource.rs, components/script/dom/serviceworkercontainer.rs, components/script/dom/cssstylesheet.rs, components/script/dom/formdata.rs
  • @emilio: components/script/dom/webglrenderingcontext.rs, components/script/dom/webglprogram.rs

@highfive
Copy link
Copy Markdown

highfive commented Dec 8, 2016

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Dec 8, 2016
@frewsxcv frewsxcv mentioned this pull request Dec 8, 2016
Closed
@frewsxcv
Copy link
Copy Markdown
Contributor Author

frewsxcv commented Dec 8, 2016

r? @nox @Ms2ger

@highfive highfive assigned nox and unassigned KiChjang Dec 8, 2016
@Ms2ger
Copy link
Copy Markdown
Contributor

Ms2ger commented Dec 8, 2016

401 @jdm

@jdm
Copy link
Copy Markdown
Member

jdm commented Dec 8, 2016

@bors-servo: r+

@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Dec 8, 2016

📌 Commit 449f633 has been approved by jdm

@highfive highfive assigned jdm and unassigned nox Dec 8, 2016
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Dec 8, 2016
@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Dec 8, 2016

⌛ Testing commit 449f633 with merge b192ae9...

bors-servo pushed a commit that referenced this pull request Dec 8, 2016
Auto merge of #14495 - frewsxcv:reflectable-domobject, r=jdm
b192ae9 
Rename `Reflectable` to `DomObject`.

Fixes #8473.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14495)
<!-- Reviewable:end -->
@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Dec 8, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev

@bors-servo bors-servo merged commit 449f633 into servo:master Dec 8, 2016
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Dec 8, 2016
@bors-servo bors-servo mentioned this pull request Dec 8, 2016
Merged
5 tasks
@frewsxcv frewsxcv deleted the reflectable-domobject branch July 18, 2017 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jdm jdm

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@frewsxcv @highfive @Ms2ger @jdm @bors-servo @nox @KiChjang