Allow multiple -Z debug options.#14313
Merged
bors-servo merged 1 commit intoservo:masterfrom Nov 22, 2016
Merged
Conversation
highfive
added
the
S-awaiting-review
Contributor
Author
Contributor
|
@bors-servo r+ |
Contributor
|
📌 Commit 358a7e2 has been approved by |
highfive
added
S-awaiting-merge
Contributor
bors-servo
pushed a commit
that referenced
this pull request
Nov 22, 2016
Allow multiple -Z debug options. <!-- Please describe your changes on the following line: --> This PR allows the `-Z` command line option to be set multiple times; `servo -Zfoo -Zbar` is the same as `servo -Zfoo,bar`. This means we can pass debug options into `mach test-wpt` as `mach test-wpt --binary-arg=-Zfoo`; previously this failed because mach already passed in some debug options. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because this is part of the debug and test architecture <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14313) <!-- Reviewable:end -->
Contributor
|
☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev |
highfive
removed
the
S-awaiting-merge
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows the
-Zcommand line option to be set multiple times;servo -Zfoo -Zbaris the same asservo -Zfoo,bar. This means we can pass debug options intomach test-wptasmach test-wpt --binary-arg=-Zfoo; previously this failed because mach already passed in some debug options../mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is