Move the servo binary to ports. by Ms2ger · Pull Request #14172 · servo/servo

Ms2ger · 2016-11-11T12:38:18Z

This change is

highfive · 2016-11-11T12:38:21Z

Heads up! This PR modifies the following files:

@wafflespeanut: python/servo/command_base.py, python/servo/build_commands.py

highfive · 2016-11-11T12:38:22Z

Warning

These commits modify unsafe code. Please review it carefully!

Ms2ger · 2016-11-11T12:38:34Z

CC @paulrouget

SimonSapin · 2016-11-11T13:06:58Z

ports/servo/Cargo.toml

+[dependencies]
+backtrace = "0.2"
+browserhtml = {git = "https://github.com/browserhtml/browserhtml", branch = "crate"}
+glutin_app = {path = "../../ports/glutin"}


Can / should this new servo crate be merged with the glutin_app crate?

cef uses glutin_app as well

jdm · 2016-11-11T17:54:30Z

./ports/servo/Cargo.toml:0: .toml file should contain a valid license.

jdm · 2016-11-11T17:54:39Z

@bors-servo: try

bors-servo · 2016-11-11T17:54:43Z

⌛ Trying commit e0b1ffb with merge 6b332db...

Move the servo binary to ports.  This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14172)

bors-servo · 2016-11-11T18:06:06Z

💔 Test failed - linux-dev

jdm · 2016-11-11T19:33:58Z

error: no matching package named `servo` found (required by `embedding`)
location searched: file:///home/servo/buildbot/slave/linux-dev/build/components/servo
version required: *

build-cef failed.

bors-servo · 2016-11-12T20:16:51Z

☔ The latest upstream changes (presumably #14177) made this pull request unmergeable. Please resolve the merge conflicts.

Ms2ger · 2016-11-13T10:31:17Z

@bors-servo try

bors-servo · 2016-11-13T10:31:19Z

⌛ Trying commit 8fc4d9f with merge 40b3a8b...

Move the servo binary to ports.  This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14172)

bors-servo · 2016-11-13T10:52:29Z

💔 Test failed - mac-rel-wpt1

jdm · 2016-11-13T14:48:21Z

   Compiling servo v0.0.1 (file:///Users/servo/buildbot/slave/mac-rel-wpt1/build/ports/servo)
error: file not found for module `macos`
  --> main.rs:52:13
   |
52 |     pub mod macos;
   |             ^^^^^
   |
   = help: name the file either macos.rs or macos/mod.rs inside the directory "platform"

Ms2ger · 2016-11-14T07:57:24Z

@bors-servo try

bors-servo · 2016-11-14T07:57:28Z

⌛ Trying commit f19b36d with merge 0b4b3b9...

Move the servo binary to ports.  This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14172)

Ms2ger · 2016-11-14T10:42:08Z

@bors-servo try

bors-servo · 2016-11-16T16:57:45Z

💔 Test failed - linux-rel-css

highfive · 2016-11-16T16:57:49Z

  ▶ TIMEOUT [expected PASS] /css21_dev/html4/margin-bottom-044.htm
  │ 
  │ VMware, Inc.
  │ Gallium 0.4 on softpipe
  └ 3.3 (Core Profile) Mesa 12.0.1

  ▶ TIMEOUT [expected PASS] /css21_dev/html4/margin-bottom-056.htm
  │ 
  │ VMware, Inc.
  │ Gallium 0.4 on softpipe
  │ 3.3 (Core Profile) Mesa 12.0.1
  └ Shutting down the Constellation after generating an output file or exit flag specified

Manishearth · 2016-11-16T17:25:29Z

@bors-servo retry

Intermittent timeout in /css21_dev/html4/margin-bottom-055.htm, /css21_dev/html4/margin-bottom-043.htm, /css21_dev/html4/margin-bottom-044.htm, /css21_dev/html4/margin-bottom-056.htm, /css21_dev/html4/margin-top-056.htm, /css21_dev/html4/bottom-019.htm, /css21_dev/html4/bottom-031.htm, /css21_dev/html4/bottom-068.htm, /css21_dev/html4/bottom-103.htm, /css21_dev/html4/bottom-104.htm, /css21_dev/html4/bottom-113.htm, /css21_dev/html4/padding-top-058.htm, /css-backgrounds-3_dev/html4/box-shadow-syntax-001.htm, /_mozilla/css/borders_a.html, /css21_dev/html4/padding-bottom-050.htm, /css21_dev/html4/padding-top-039.htm, /css21_dev/html4/padding-top-051.htm, /css/css-backgrounds/box-shadow-syntax-001.xht #14237

bors-servo · 2016-11-16T17:39:30Z

⚡ Previous build results for arm32, arm64, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev are reusable. Rebuilding only linux-rel-css, linux-rel-wpt...

bors-servo · 2016-11-16T19:01:46Z

💔 Test failed - linux-rel-css

Manishearth · 2016-11-16T19:04:05Z

@bors-servo retry

bors-servo · 2016-11-16T22:40:19Z

⌛ Testing commit 9a5abab with merge f14e733...

Move the servo binary to ports.  This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14172)

bors-servo · 2016-11-16T23:57:44Z

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev

Manishearth · 2016-11-17T00:47:31Z

This broke the doc build. The docs are likely living in the wrong folder now.

Fixes `./mach doc` regression caused by servo#14172.

highfive assigned jdm Nov 11, 2016

highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 11, 2016

SimonSapin reviewed Nov 11, 2016

View reviewed changes

jdm added the S-fails-tidy `./mach test-tidy` reported errors. label Nov 11, 2016

highfive added the S-tests-failed The changes caused existing tests to fail. label Nov 11, 2016

highfive added S-needs-rebase There are merge conflict errors. and removed S-tests-failed The changes caused existing tests to fail. labels Nov 12, 2016

Ms2ger force-pushed the ports branch from 948cfdb to 8fc4d9f Compare November 13, 2016 10:31

highfive added the S-tests-failed The changes caused existing tests to fail. label Nov 13, 2016

highfive removed the S-tests-failed The changes caused existing tests to fail. label Nov 14, 2016

Ms2ger force-pushed the ports branch from f19b36d to 81070b4 Compare November 14, 2016 10:41

highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Nov 16, 2016

highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Nov 16, 2016

highfive added the S-tests-failed The changes caused existing tests to fail. label Nov 16, 2016

highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Nov 16, 2016

bors-servo merged commit 9a5abab into master Nov 16, 2016

highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 16, 2016

Manishearth deleted the ports branch November 17, 2016 00:49

mbrubeck added a commit to mbrubeck/servo that referenced this pull request Nov 17, 2016

Run cargo doc on libservo crate

39a221a

Fixes `./mach doc` regression caused by servo#14172.

mbrubeck mentioned this pull request Nov 17, 2016

Run cargo doc on libservo crate #14254

Merged

kvark mentioned this pull request Nov 17, 2016

Updated cargo paths for the python script #14266

Merged

5 tasks

Uh oh!

Conversation

Ms2ger commented Nov 11, 2016 • edited by larsbergstrom Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

highfive commented Nov 11, 2016

Uh oh!

highfive commented Nov 11, 2016

Uh oh!

Ms2ger commented Nov 11, 2016

Uh oh!

SimonSapin Nov 11, 2016

Choose a reason for hiding this comment

Uh oh!

Ms2ger Nov 11, 2016

Choose a reason for hiding this comment

Uh oh!

jdm commented Nov 11, 2016

Uh oh!

jdm commented Nov 11, 2016

Uh oh!

bors-servo commented Nov 11, 2016

Uh oh!

bors-servo commented Nov 11, 2016

Uh oh!

jdm commented Nov 11, 2016

Uh oh!

bors-servo commented Nov 12, 2016

Uh oh!

Ms2ger commented Nov 13, 2016

Uh oh!

bors-servo commented Nov 13, 2016

Uh oh!

bors-servo commented Nov 13, 2016

Uh oh!

jdm commented Nov 13, 2016

Uh oh!

Ms2ger commented Nov 14, 2016

Uh oh!

bors-servo commented Nov 14, 2016

Uh oh!

Ms2ger commented Nov 14, 2016

Uh oh!

bors-servo commented Nov 16, 2016

Uh oh!

highfive commented Nov 16, 2016

Uh oh!

Manishearth commented Nov 16, 2016

Uh oh!

bors-servo commented Nov 16, 2016

Uh oh!

bors-servo commented Nov 16, 2016

Uh oh!

Manishearth commented Nov 16, 2016

Uh oh!

bors-servo commented Nov 16, 2016

Uh oh!

bors-servo commented Nov 16, 2016

Uh oh!

Manishearth commented Nov 17, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Ms2ger commented Nov 11, 2016 •

edited by larsbergstrom

Loading