Move remaining users of the legacy networking stack to fetch. by Ms2ger · Pull Request #13961 · servo/servo

Ms2ger · 2016-10-28T15:11:54Z

Fixes #13931.
Fixes #13714.

This change is

highfive · 2016-10-28T15:11:57Z

Heads up! This PR modifies the following files:

@fitzgen: components/script/network_listener.rs, components/script/dom/workerglobalscope.rs, components/script/dom/dedicatedworkerglobalscope.rs, components/script/script_thread.rs, components/script/dom/servoparser/mod.rs, components/script_traits/lib.rs, components/script_traits/lib.rs, components/script/dom/serviceworkerglobalscope.rs
@KiChjang: components/net/fetch/methods.rs, components/net/resource_thread.rs, components/net/http_loader.rs, components/script/network_listener.rs, components/script/dom/workerglobalscope.rs, components/script/dom/dedicatedworkerglobalscope.rs, components/net_traits/lib.rs, components/net_traits/lib.rs, components/script/script_thread.rs, components/script/dom/servoparser/mod.rs, components/script_traits/lib.rs, components/script_traits/lib.rs, components/net_traits/response.rs, components/net_traits/response.rs, components/script/dom/serviceworkerglobalscope.rs, components/net/image_cache_thread.rs

Ms2ger · 2016-10-28T15:12:00Z

@bors-servo try

bors-servo · 2016-10-28T15:12:03Z

⌛ Trying commit 9856ccf with merge b883928...

[WIP] Sync fetch

bors-servo · 2016-10-28T15:44:26Z

💔 Test failed - linux-rel-wpt

jdm · 2016-10-29T21:07:44Z

@bors-servo: retry

bors-servo · 2016-10-29T21:17:05Z

⌛ Trying commit 9856ccf with merge 1b77dfa...

[WIP] Sync fetch  This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13961)

bors-servo · 2016-10-29T22:25:09Z

💔 Test failed - mac-rel-wpt2

KiChjang · 2016-10-30T00:59:46Z


+    // Step 14.
+    if credentials_flag {
+        // TODO: should block cookies?


The context parameter contains an http_state which in turns contains a content_blocker of type RuleList which has rules that tell us whether cookies should be blocked.

Ms2ger · 2016-10-31T15:12:10Z

  ▶ CRASH [expected OK] /workers/Worker_cross_origin_security_err.htm
  │ 
  │ VMware, Inc.
  │ Gallium 0.4 on softpipe
  │ 3.3 (Core Profile) Mesa 12.0.1
  │ Unimplemented scheme for Fetch (thread fetch thread for ftp://example.org/support/WorkerBasic.js, at /Users/servo/buildbot/slave/mac-rel-wpt2/build/components/net/fetch/methods.rs:496)
  │ stack backtrace:
  │    0:        0x10923c63e - backtrace::backtrace::trace::h6ac07ced1b846a59
  │    1:        0x10923c92c - backtrace::capture::Backtrace::new::h1d3339ed08c7f861
  │    2:        0x108018d74 - servo::main::_{{closure}}::hce6009c73746ec98
  │    3:        0x1099d55f3 - std::panicking::rust_panic_with_hook::hcd9d05f53fa0dafc
  │    4:        0x10818f694 - std::panicking::begin_panic::hc03e2830c2c89a5f
  │    5:        0x108276780 - net::fetch::methods::basic_fetch::ha806911f4cd925a5
  │    6:        0x108272a9a - net::fetch::methods::main_fetch::hb454a78ecbf1c83c
  │    7:        0x10819053a - std::panicking::try::do_call::h1db0bf7c9a597e4b
  │    8:        0x1099d661a - __rust_maybe_catch_panic
  │    9:        0x1081cc206 - _<F as alloc..boxed..FnBox<A>>::call_box::h3a6dba867d2cc296
  │   10:        0x1099d44a4 - std::sys::thread::Thread::new::thread_start::h50b05608a499d2b2
  │   11:     0x7fff88879059 - _pthread_body
  │   12:     0x7fff88878fd6 - _pthread_start
  │ ERROR:servo: Unimplemented scheme for Fetch
  │ Pipeline failed in hard-fail mode.  Crashing!
  └ thread panicked while processing panic. aborting.

Looks like that's the only problem. I think I'll just change to returning network errors for ftp fetches.

r? @jdm, but review the dependent PRs first :)

bors-servo · 2016-11-02T09:29:30Z

☔ The latest upstream changes (presumably #13742) made this pull request unmergeable. Please resolve the merge conflicts.

Ms2ger · 2016-11-02T10:54:30Z

@bors-servo try

bors-servo · 2016-11-02T10:54:33Z

⌛ Trying commit 98ed8d7 with merge 8a975c8...

[WIP] Sync fetch  This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13961)

bors-servo · 2016-11-02T11:54:35Z

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev

jdm · 2016-11-02T13:48:43Z

This is good to merge once #13931 merges.

This matches the previous default (network.mime.sniff off) behaviour in all but one case: we will now accept a font without a `Content-Type` header, which would previously have been ignored.

Ms2ger · 2016-11-02T15:58:59Z

@bors-servo r=jdm

Let's land them all at once.

bors-servo · 2016-11-02T15:59:10Z

📌 Commit cecd60b has been approved by jdm

bors-servo · 2016-11-02T15:59:19Z

⌛ Testing commit cecd60b with merge 56f4a69...

Move remaining users of the legacy networking stack to fetch. Fixes #13931. Fixes #13714.

bors-servo · 2016-11-02T17:00:07Z

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev

highfive assigned glennw Oct 28, 2016

highfive added the S-awaiting-review There is new code that needs to be reviewed. label Oct 28, 2016

bors-servo pushed a commit that referenced this pull request Oct 28, 2016

Auto merge of #13961 - servo:sync-fetch, r=<try>

b883928

[WIP] Sync fetch

highfive added the S-tests-failed The changes caused existing tests to fail. label Oct 28, 2016

highfive added the S-tests-failed The changes caused existing tests to fail. label Oct 29, 2016

KiChjang reviewed Oct 30, 2016

View reviewed changes

jdm added S-blocked-on-external Something, somewhere else, needs to happen before this PR can be merged. and removed S-awaiting-review There is new code that needs to be reviewed. labels Oct 31, 2016

jdm assigned jdm and unassigned glennw Oct 31, 2016

highfive added the S-needs-rebase There are merge conflict errors. label Nov 2, 2016

Ms2ger force-pushed the sync-fetch branch from 9856ccf to ebae89a Compare November 2, 2016 10:37

highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Nov 2, 2016

Ms2ger force-pushed the sync-fetch branch from ebae89a to 98ed8d7 Compare November 2, 2016 10:52

Ms2ger force-pushed the sync-fetch branch from 98ed8d7 to 9213198 Compare November 2, 2016 15:09

highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 2, 2016

Ms2ger added 13 commits November 2, 2016 16:15

Ignore the Content-Type header completely for @font-face.

44c80d5

This matches the previous default (network.mime.sniff off) behaviour in all but one case: we will now accept a font without a `Content-Type` header, which would previously have been ignored.

Implement fetch_async in net_traits.

a79c06d

Use fetch_async in the font cache.

953fa89

Remove load_async.

e844a36

Use fetch_async in the image cache.

e8d9546

Remove LoadConsumer::Listener.

40c711b

Remove unused argument to start_sending_opt.

8a60160

Remove ProgressSender::Listener.

fe3d512

Remove AsyncResponseTarget.

4bbeecb

Move ResponseAction to the image cache.

634a398

Stop panicking when trying to load ftp URLs.

479cf1e

Rewrite load_whole_resource using the fetch stack.

c3c6df6

Remove the unused LoadOrigin implementation from WorkerScriptLoadOrigin.

cecd60b

Ms2ger force-pushed the sync-fetch branch from 9213198 to cecd60b Compare November 2, 2016 15:57

Ms2ger changed the title ~~[WIP] Sync fetch~~ Move remaining users of the legacy networking stack to fetch. Nov 2, 2016

highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Nov 2, 2016

bors-servo pushed a commit that referenced this pull request Nov 2, 2016

Auto merge of #13961 - servo:sync-fetch, r=jdm

56f4a69

Move remaining users of the legacy networking stack to fetch. Fixes #13931. Fixes #13714.

highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 2, 2016

bors-servo merged commit cecd60b into master Nov 2, 2016

highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 2, 2016

This was referenced Nov 2, 2016

Ignore the Content-Type header completely for @font-face. #13931

Closed

Move some types out of msg. #13816

Merged

SimonSapin deleted the sync-fetch branch November 3, 2016 10:29

Ms2ger mentioned this pull request Nov 7, 2016

Remove the legacy networking stack #14115

Closed

31 tasks

Uh oh!

Conversation

Ms2ger commented Oct 28, 2016 • edited by larsbergstrom Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

highfive commented Oct 28, 2016

Uh oh!

Ms2ger commented Oct 28, 2016

Uh oh!

bors-servo commented Oct 28, 2016

Uh oh!

bors-servo commented Oct 28, 2016

Uh oh!

jdm commented Oct 29, 2016

Uh oh!

bors-servo commented Oct 29, 2016

Uh oh!

bors-servo commented Oct 29, 2016

Uh oh!

KiChjang Oct 30, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Ms2ger commented Oct 31, 2016

Uh oh!

bors-servo commented Nov 2, 2016

Uh oh!

Ms2ger commented Nov 2, 2016

Uh oh!

bors-servo commented Nov 2, 2016

Uh oh!

bors-servo commented Nov 2, 2016

Uh oh!

jdm commented Nov 2, 2016

Uh oh!

Ms2ger commented Nov 2, 2016

Uh oh!

bors-servo commented Nov 2, 2016

Uh oh!

bors-servo commented Nov 2, 2016

Uh oh!

bors-servo commented Nov 2, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Ms2ger commented Oct 28, 2016 •

edited by larsbergstrom

Loading

KiChjang Oct 30, 2016 •

edited

Loading