Ignore the Content-Type header completely for @font-face.#13931
Closed
Ignore the Content-Type header completely for @font-face.#13931
Conversation
highfive
added
the
S-awaiting-review
Contributor
Author
Member
|
Could you explain how these changes unblock #13714 and what they are intended to do? |
jdm
added
S-awaiting-answer
Contributor
Author
|
I added a long commit message that should hopefully help. |
Ms2ger
removed
the
S-awaiting-answer
Member
|
As discussed on IRC, I would like to see either the test removed along with all code that deals with the content type of font responses (along with an issue filed about implementing sniffing for fetch), or implementing sniffing for fetch properly. |
jdm
added
S-needs-code-changes
highfive
added
S-awaiting-review
Ms2ger
changed the title
Contributor
Author
Member
|
@bors-servo: r+ |
Contributor
|
📌 Commit 4f02413 has been approved by |
highfive
added
S-awaiting-merge
This matches the previous default (network.mime.sniff off) behaviour in all but one case: we will now accept a font without a `Content-Type` header, which would previously have been ignored.
highfive
removed
the
S-awaiting-merge
Contributor
Author
|
Also removed the now-unused dependency on the mime crate. @bors-servo r=jdm |
Contributor
|
📌 Commit 7c17529 has been approved by |
highfive
added
S-awaiting-merge
Member
|
@bors-servo: r- |
jdm
added
S-needs-code-changes
Contributor
|
☔ The latest upstream changes (presumably #13961) made this pull request unmergeable. Please resolve the merge conflicts. |
31 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This matches the previous default (network.mime.sniff off) behaviour in all
but one case: we will now accept a font without a
Content-Typeheader, whichwould previously have been ignored.
This change is