Skip to content

Move LoadData to script_traits.#13878

Merged
bors-servo merged 1 commit intomasterfrom
msg-min
Oct 21, 2016
Merged

Move LoadData to script_traits.#13878
bors-servo merged 1 commit intomasterfrom
msg-min

Conversation

@Ms2ger
Copy link
Copy Markdown
Contributor

@Ms2ger Ms2ger commented Oct 21, 2016 •
edited by larsbergstrom
Loading

This change is Reviewable

@highfive
Copy link
Copy Markdown

highfive commented Oct 21, 2016

Heads up! This PR modifies the following files:

  • @asajeffrey: components/webdriver_server/lib.rs, components/constellation/constellation.rs, components/constellation/pipeline.rs
  • @jgraham: components/webdriver_server/lib.rs
  • @fitzgen: components/script/dom/htmliframeelement.rs, components/script/dom/htmlformelement.rs, components/script_traits/script_msg.rs, components/script_traits/script_msg.rs, components/script/script_thread.rs, components/script/dom/window.rs, components/script_traits/Cargo.toml, components/script_traits/Cargo.toml, components/script_traits/lib.rs, components/script_traits/lib.rs
  • @KiChjang: components/script/dom/htmliframeelement.rs, components/script/dom/htmlformelement.rs, components/script_traits/script_msg.rs, components/script_traits/script_msg.rs, components/script/script_thread.rs, components/script/dom/window.rs, components/script_traits/Cargo.toml, components/script_traits/Cargo.toml, components/script_traits/lib.rs, components/script_traits/lib.rs

@highfive
Copy link
Copy Markdown

highfive commented Oct 21, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Oct 21, 2016
@Ms2ger
Copy link
Copy Markdown
Contributor Author

Ms2ger commented Oct 21, 2016

@bors-servo r=nox

Reviewed in #13816.

@highfive highfive assigned nox and unassigned jdm Oct 21, 2016
@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Oct 21, 2016

📌 Commit e97f068 has been approved by nox

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Oct 21, 2016
@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Oct 21, 2016

⌛ Testing commit e97f068 with merge e3ebbd0...

bors-servo pushed a commit that referenced this pull request Oct 21, 2016
Auto merge of #13878 - servo:msg-min, r=nox
e3ebbd0 
Move LoadData to script_traits.
@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Oct 21, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev

@bors-servo bors-servo merged commit e97f068 into master Oct 21, 2016
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 21, 2016
This was referenced Oct 21, 2016
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nox nox

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Ms2ger @highfive @bors-servo @jdm @nox