Heads up! This PR modifies the following files:

• @KiChjang: components/script/dom/document.rs, components/net/resource_thread.rs, components/script/network_listener.rs, components/net_traits/lib.rs, components/net_traits/lib.rs, components/script/dom/servoparser/mod.rs, components/script/document_loader.rs, components/script/script_thread.rs, components/net/image_cache_thread.rs

Warning

• These commits modify net, gfx, and script code, but no tests are modified. Please consider adding a test!

I need spec links on each of the RequestInit ctors.

Reviewed 2 of 2 files at r1, 2 of 2 files at r2, 2 of 2 files at r3, 2 of 2 files at r4, 1 of 1 files at r5, 1 of 1 files at r6, 1 of 1 files at r7, 1 of 1 files at r8, 2 of 2 files at r9, 1 of 1 files at r10, 1 of 1 files at r11, 1 of 1 files at r12, 2 of 2 files at r13.
Review status: all files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.

components/net/image_cache_thread.rs, line 536 at r8 (raw file):

                                FetchResponseMsg::ProcessRequestEOF => return,
                                FetchResponseMsg::ProcessResponse(meta_result) => {
                                    ResponseAction::HeadersAvailable(meta_result.map(|m| {

Do we need ResponseAction anymore? We can just proxy the FetchResponseMsg through

components/net/image_cache_thread.rs, line 228 at r13 (raw file):

}

/// Data for passing between threads/processes to indicate a particular action to

If we're not removing this, make this comment reflect what specifically this is used for here

components/script/dom/servoparser/mod.rs, line 345 at r3 (raw file):

            Ok(meta) => {
                Some(match meta {
                    FetchMetadata::Unfiltered(m) => m,

might be useful as a convenience method, FetchMetadata.unwrap_ufiltered() or something

Comments from Reviewable

@bors-servo r=Manishearth

📌 Commit 8fbf382 has been approved by Manishearth

@bors-servo r-

Apparently not

@bors-servo r+

📌 Commit 8fbf382 has been approved by Manishearth

@bors-servo p=1

⌛ Testing commit 8fbf382 with merge 7c295d7...

💔 Test failed - linux-rel-wpt

Looks like I'll need to support blob URLs. I'll check tomorrow if I can land some parts of this PR independently.

☔ The latest upstream changes (presumably #13711) made this pull request unmergeable. Please resolve the merge conflicts.

@bors-servo r+

Currently, this is hitting a timeout in tests/wpt/mozilla/tests/mozilla/mime_sniffing_font_context.html; if I understand correctly, that's because there is sniffing code in the old networking stack that isn't in the fetch stack. I'd argue it would be better to break the test for now, for two reasons in particular. First, it really isn't the networking stack's job to sniff bytes; the consumer should ignore the metadata rather than expecting the networking layer to mess with it. Second, I'd generally prefer not to add too much code to the fetch stack before the old stack is gone, and we've been able to simplify the fetch code a little.

I'll leave it to @jdm to decide whether that's a good idea.

Perhaps it makes sense to open a tracking issue for this?

☔ The latest upstream changes (presumably #13742) made this pull request unmergeable. Please resolve the merge conflicts.

I reviewed these commits by accident in #13961.

☔ The latest upstream changes (presumably #13961) made this pull request unmergeable. Please resolve the merge conflicts.