Provide the fetched data to fetch() consumers. by Ms2ger · Pull Request #13597 · servo/servo

Ms2ger · 2016-10-05T13:28:12Z

This change is

highfive · 2016-10-05T13:28:16Z

Heads up! This PR modifies the following files:

@KiChjang: components/script/dom/request.rs, components/script/fetch.rs, components/script/dom/response.rs, components/script/body.rs

Ms2ger · 2016-10-05T13:28:20Z

@bors-servo try

bors-servo · 2016-10-05T13:28:22Z

⌛ Trying commit 7ac1910 with merge e447d56...

Provide the fetched data to fetch() consumers.

jdm · 2016-10-05T13:39:17Z

components/script/dom/request.rs


+    fn set_body_promise(&self, p: &Rc<Promise>, body_type: BodyType) {
+        self.body_used.set(true);
+        assert!(mem::replace(&mut *self.body_promise.borrow_mut(), Some((p.clone(), body_type))).is_none());


Same as later comment.

jdm · 2016-10-05T13:39:19Z

components/script/dom/response.rs


+    fn set_body_promise(&self, p: &Rc<Promise>, body_type: BodyType) {
+        self.body_used.set(true);
+        assert!(mem::replace(&mut *self.body_promise.borrow_mut(), Some((p.clone(), body_type))).is_none());


This is a complicated way of writing

assert!(self.body_promise.borrow().is_none()); *self.body_promise.borrow_mut() = Some(p.clone(), body_type);

which I would prefer.

jdm · 2016-10-05T13:40:49Z

components/script/body.rs

+}
+
+// https://fetch.spec.whatwg.org/#concept-body-consume-body
+#[allow(unrooted_must_root)]


Is this necessary?

jdm · 2016-10-05T13:41:46Z

components/script/body.rs

-            };
-        },
-        Err(err) => promise.reject_error(cx, err),
+    if let Some(body) = object.take_body() {


let body = match object.take_body() { Some(body) => body, None => return, };

bors-servo · 2016-10-05T14:00:34Z

💔 Test failed - mac-rel-wpt1

Ms2ger · 2016-10-05T14:37:37Z

@bors-servo try

bors-servo · 2016-10-05T14:37:39Z

⌛ Trying commit c805e3b with merge 1a28907...

Provide the fetched data to fetch() consumers.  This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13597)

bors-servo · 2016-10-05T15:09:44Z

💔 Test failed - linux-rel-wpt

jdm · 2016-10-05T15:14:03Z

We probably need a compartment for the JSON case.

Ms2ger · 2016-10-06T10:00:13Z

@bors-servo try

bors-servo · 2016-10-06T10:00:16Z

⌛ Trying commit 8f6a0b7 with merge 3ca06c1...

Provide the fetched data to fetch() consumers.  This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13597)

bors-servo · 2016-10-06T10:32:27Z

💔 Test failed - mac-rel-wpt1

bors-servo · 2016-10-06T13:57:55Z

⌛ Testing commit cd47e21 with merge 113ef4c...

Provide the fetched data to fetch() consumers.  This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13597)

bors-servo · 2016-10-06T14:46:23Z

💔 Test failed - mac-rel-css

Ms2ger · 2016-10-06T15:00:58Z

@bors-servo retry

bors-servo · 2016-10-06T15:25:25Z

⌛ Testing commit cd47e21 with merge 0d25bc9...

Provide the fetched data to fetch() consumers.  This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13597)

larsbergstrom · 2016-10-06T15:50:51Z

@bors-servo clean force retry

infra buildbot restart

bors-servo · 2016-10-06T15:56:31Z

⌛ Testing commit cd47e21 with merge f1c3288...

Provide the fetched data to fetch() consumers.  This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13597)

bors-servo · 2016-10-06T16:13:40Z

💔 Test failed - linux-dev

Ms2ger · 2016-10-06T16:17:36Z

Oh what the hell:

LLVM ERROR: IO failure on output stream.

twice on servo-linux2

@larsbergstrom ?

larsbergstrom · 2016-10-06T16:24:10Z

@Ms2ger disk full, please retry.

larsbergstrom · 2016-10-06T16:30:36Z

@bors-servo retry

infra

bors-servo · 2016-10-06T17:34:02Z

⌛ Testing commit cd47e21 with merge bd05aa2...

Provide the fetched data to fetch() consumers.  This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13597)

bors-servo · 2016-10-06T18:27:25Z

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev

highfive assigned glennw Oct 5, 2016

highfive added the S-awaiting-review There is new code that needs to be reviewed. label Oct 5, 2016

bors-servo pushed a commit that referenced this pull request Oct 5, 2016

Auto merge of #13597 - servo:fetch, r=<try>

e447d56

Provide the fetched data to fetch() consumers.

jdm requested changes Oct 5, 2016

View reviewed changes

jdm assigned jdm and unassigned glennw Oct 5, 2016

jdm added S-needs-code-changes Changes have not yet been made that were requested by a reviewer. and removed S-awaiting-review There is new code that needs to be reviewed. labels Oct 5, 2016

highfive added the S-tests-failed The changes caused existing tests to fail. label Oct 5, 2016

highfive removed the S-tests-failed The changes caused existing tests to fail. label Oct 6, 2016

highfive added the S-tests-failed The changes caused existing tests to fail. label Oct 6, 2016

Ms2ger added 2 commits October 6, 2016 14:21

Provide the fetched data to fetch() consumers.

cb7e671

Enable some referrer-policy tests now that they no longer time out.

cd47e21

highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Oct 6, 2016

highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Oct 6, 2016

highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Oct 6, 2016

larsbergstrom mentioned this pull request Oct 6, 2016

Need to periodically clean up buildbot slave directories servo/saltfs#506

Open

highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Oct 6, 2016

bors-servo merged commit cd47e21 into master Oct 6, 2016

highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 6, 2016

bors-servo mentioned this pull request Oct 6, 2016

Get rid of dom::bindings::global #13596

Merged

SimonSapin deleted the fetch branch November 3, 2016 10:30

Ms2ger mentioned this pull request Nov 7, 2016

Remove the legacy networking stack #14115

Closed

31 tasks

Uh oh!

Conversation

Ms2ger commented Oct 5, 2016 • edited by larsbergstrom Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

highfive commented Oct 5, 2016

Uh oh!

Ms2ger commented Oct 5, 2016

Uh oh!

bors-servo commented Oct 5, 2016

Uh oh!

jdm Oct 5, 2016

Choose a reason for hiding this comment

Uh oh!

jdm Oct 5, 2016

Choose a reason for hiding this comment

Uh oh!

jdm Oct 5, 2016

Choose a reason for hiding this comment

Uh oh!

Ms2ger Oct 6, 2016

Choose a reason for hiding this comment

Uh oh!

jdm Oct 5, 2016

Choose a reason for hiding this comment

Uh oh!

bors-servo commented Oct 5, 2016

Uh oh!

Ms2ger commented Oct 5, 2016

Uh oh!

bors-servo commented Oct 5, 2016

Uh oh!

bors-servo commented Oct 5, 2016

Uh oh!

jdm commented Oct 5, 2016

Uh oh!

Ms2ger commented Oct 6, 2016

Uh oh!

bors-servo commented Oct 6, 2016

Uh oh!

bors-servo commented Oct 6, 2016

Uh oh!

bors-servo commented Oct 6, 2016

Uh oh!

bors-servo commented Oct 6, 2016

Uh oh!

Ms2ger commented Oct 6, 2016

Uh oh!

bors-servo commented Oct 6, 2016

Uh oh!

larsbergstrom commented Oct 6, 2016

Uh oh!

bors-servo commented Oct 6, 2016

Uh oh!

bors-servo commented Oct 6, 2016

Uh oh!

Ms2ger commented Oct 6, 2016

Uh oh!

larsbergstrom commented Oct 6, 2016

Uh oh!

larsbergstrom commented Oct 6, 2016

Uh oh!

bors-servo commented Oct 6, 2016

Uh oh!

bors-servo commented Oct 6, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Ms2ger commented Oct 5, 2016 •

edited by larsbergstrom

Loading