Inline push_pending_frame into its callers.#13334
Merged
bors-servo merged 1 commit intomasterfrom Sep 20, 2016
Merged
Conversation
The recently added replace argument makes it less readable, especially with the second boolean argument I am adding in #11893.
|
Heads up! This PR modifies the following files:
|
highfive
added
the
S-awaiting-review
Contributor
|
@bors-servo r+ |
Contributor
|
📌 Commit 61402b8 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Sep 20, 2016
Inline push_pending_frame into its callers. The recently added replace argument makes it less readable, especially with the second boolean argument I am adding in #11893. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13334) <!-- Reviewable:end -->
Contributor
Contributor
|
☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev |
highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recently added replace argument makes it less readable, especially with
the second boolean argument I am adding in #11893.
This change is