Skip to content

Make DOMJSClass use JSClass instead of Class (fixes #13031)#13062

Merged
bors-servo merged 1 commit intoservo:masterfrom
nox:bump-js
Aug 27, 2016
Merged

Make DOMJSClass use JSClass instead of Class (fixes #13031)#13062
bors-servo merged 1 commit intoservo:masterfrom
nox:bump-js

Conversation

@nox
Copy link
Copy Markdown
Contributor

@nox nox commented Aug 26, 2016

This change is Reviewable

@highfive
Copy link
Copy Markdown

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/bindings/codegen/CodegenRust.py, components/script/dom/browsingcontext.rs, components/script/dom/bindings/utils.rs

@highfive
Copy link
Copy Markdown

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify script code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Aug 26, 2016
@nox
Copy link
Copy Markdown
Contributor Author

nox commented Aug 26, 2016

@bors-servo r+

@highfive highfive assigned nox and unassigned pcwalton Aug 26, 2016
@bors-servo
Copy link
Copy Markdown
Contributor

📌 Commit 0277cf9 has been approved by nox

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Aug 26, 2016
@bors-servo
Copy link
Copy Markdown
Contributor

⌛ Testing commit 0277cf9 with merge 92776b0...

bors-servo pushed a commit that referenced this pull request Aug 26, 2016
Make DOMJSClass use JSClass instead of Class (fixes #13031)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13062)
<!-- Reviewable:end -->
@bors-servo
Copy link
Copy Markdown
Contributor

💔 Test failed - linux-rel

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Aug 26, 2016
@nox
Copy link
Copy Markdown
Contributor Author

nox commented Aug 26, 2016

@bors-servo retry #11772

@bors-servo
Copy link
Copy Markdown
Contributor

⌛ Testing commit 0277cf9 with merge fe1225b...

bors-servo pushed a commit that referenced this pull request Aug 27, 2016
Make DOMJSClass use JSClass instead of Class (fixes #13031)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13062)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Aug 27, 2016
@bors-servo
Copy link
Copy Markdown
Contributor

☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev

@bors-servo bors-servo merged commit 0277cf9 into servo:master Aug 27, 2016
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Aug 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants