Document Windows installation hacks#12578
Merged
bors-servo merged 1 commit intoservo:masterfrom Jul 25, 2016
Merged
Conversation
highfive
added
the
S-awaiting-review
Collaborator
|
@bors-servo r+ Yuck. Do we have any idea why GCC 6 is not working? |
Contributor
|
📌 Commit 94c3431 has been approved by |
highfive
added
S-awaiting-merge
Contributor
bors-servo
pushed a commit
that referenced
this pull request
Jul 25, 2016
Document Windows installation hacks <!-- Please describe your changes on the following line: --> This is based on the awesome work by @UK992 in #12573. Basically, it downgrades GCC on Windows to 5.4 within the mingw environment. This is a stopgap until #11756 is completed and we no longer need mingw. Fixes #12512 r? @metajack --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12578) <!-- Reviewable:end -->
Contributor
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev |
highfive
removed
the
S-awaiting-merge
This was referenced Jul 25, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based on the awesome work by @UK992 in #12573.
Basically, it downgrades GCC on Windows to 5.4 within the mingw environment. This is a stopgap until #11756 is completed and we no longer need mingw.
Fixes #12512
r? @metajack
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is