Update to selectors 0.8.2 (generic over atoms)#12571
Conversation
|
Heads up! This PR modifies the following files:
|
|
@bholley, you said in #12548 that instead of In rust-lang/rust-bindgen#20, it looks like these fields systematically have unsafe accessors, which I don’t think is desirable here. |
|
That bindgen PR isn't complete. I only needed unsafe fields, but I'll be adding ways for making it fully private without accessors too. |
|
Looks good modulo those issues, but please test the final result with a stylo build and make sure everything works as expected. Reviewed 4 of 10 files at r1, 23 of 26 files at r2, 4 of 4 files at r3. ports/geckolib/Cargo.lock, line 251 [r3] (raw file):
Hm, why do we need to pull in the phf stuff now? ports/geckolib/string_cache/lib.rs, line 234 [r3] (raw file):
Hm, I've been explicitly avoiding implementing such a thing because it's really easily to accidentally use these slow string comparisons. I would prefer this to not work (or at least have some kind of explicit call) for gecko atoms so that we catch cases that aren't atomized. Why do we need this, and .chars()? Comments from Reviewable |
24d6211 to
4ed7291
Compare
|
Rebased. Looks ok in a gecko/stylo build. Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed. ports/geckolib/Cargo.lock, line 251 [r3] (raw file):
|
|
☔ The latest upstream changes (presumably #12645) made this pull request unmergeable. Please resolve the merge conflicts. |
4ed7291 to
2126669
Compare
|
@SimonSapin: Sorry for the bitrot :/ This is just awaiting for review from @bholley right? |
|
I don't need to look again.r=me if the comments were addressed |
|
@bors-servo r=bholley |
|
📌 Commit 2126669 has been approved by |
Update to selectors 0.8 (generic over atoms) This removes the `[replace]` override in geckolib and therefore unblocks #12391. This includes the `gecko_string_cache` redesign discussed in #12548. r? @bholley --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #12548 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require new tests because refactor <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12571) <!-- Reviewable:end -->
|
💔 Test failed - mac-rel-css |
|
|
Picking |
|
☔ The latest upstream changes (presumably #12712) made this pull request unmergeable. Please resolve the merge conflicts. |
2126669 to
5a85f21
Compare
|
51def7e to
3ae2700
Compare
|
@bors-servo r=bholley |
|
📌 Commit 3ae2700 has been approved by |
|
🔒 Merge conflict |
|
☔ The latest upstream changes (presumably #12783) made this pull request unmergeable. Please resolve the merge conflicts. |
3ae2700 to
cf05cd9
Compare
|
@bors-servo r=bholley |
|
📌 Commit cf05cd9 has been approved by |
Update to selectors 0.8.2 (generic over atoms) This removes the `[replace]` override in geckolib and therefore unblocks #12391. This includes the `gecko_string_cache` redesign discussed in #12548. r? @bholley --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #12548 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require new tests because refactor <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12571) <!-- Reviewable:end -->
|
☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev |
This removes the
[replace]override in geckolib and therefore unblocks #12391.This includes the
gecko_string_cacheredesign discussed in #12548.r? @bholley
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is