Skip to content

Generate a list of supported DOM APIs from parsed WebIDLs.#12451

Merged
bors-servo merged 1 commit intoservo:masterfrom
jdm:generate-dom-apis
Jul 15, 2016
Merged

Generate a list of supported DOM APIs from parsed WebIDLs.#12451
bors-servo merged 1 commit intoservo:masterfrom
jdm:generate-dom-apis

Conversation

@jdm
Copy link
Copy Markdown
Member

@jdm jdm commented Jul 14, 2016 •
edited by larsbergstrom
Loading

Supplement the existing list of supported CSS properties with an equivalent list of DOM APIs.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes do not require tests because automatic generated documentation

This change is Reviewable

@highfive
Copy link
Copy Markdown

highfive commented Jul 14, 2016

Heads up! This PR modifies the following files:

  • @aneeshusa: etc/ci/upload_docs.sh
  • @KiChjang: components/script/dom/bindings/codegen/CodegenRust.py, components/script/dom/bindings/codegen/apis.html.template, components/script/dom/bindings/codegen/GlobalGen.py, components/script/makefile.cargo, components/script/dom/bindings/codegen/property.html.template, components/script/dom/bindings/codegen/api.html.template, components/script/dom/bindings/codegen/interface.html.template, components/script/dom/bindings/codegen/Configuration.py

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jul 14, 2016
@highfive
Copy link
Copy Markdown

highfive commented Jul 14, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!

aneeshusa
aneeshusa reviewed Jul 14, 2016
View reviewed changes
etc/ci/upload_docs.sh Outdated

python components/style/properties/build.py servo html

OUT_DIR=`pwd`/target/doc make -f makefile.cargo -C components/script dom_docs
Copy link
Copy Markdown
Contributor

@aneeshusa aneeshusa Jul 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use OUT_DIR="$(pwd)/target/doc" per the style guide.

@jdm
Copy link
Copy Markdown
Member Author

jdm commented Jul 14, 2016

r? @metajack

@highfive highfive assigned metajack and unassigned pcwalton Jul 14, 2016
@jdm
Copy link
Copy Markdown
Member Author

jdm commented Jul 14, 2016

Sample output: http://www.joshmatthews.net/apis.html

@jdm jdm force-pushed the generate-dom-apis branch from f52db2c to 60a2638 Compare July 14, 2016 21:15
@Ms2ger
Copy link
Copy Markdown
Contributor

Ms2ger commented Jul 15, 2016

We might want to show something nicer than __namedgetter(); looks fine otherwise.

@jdm jdm force-pushed the generate-dom-apis branch from 60a2638 to 052c018 Compare July 15, 2016 22:11
@jdm
Copy link
Copy Markdown
Member Author

jdm commented Jul 15, 2016

I hid every method that doesn't have an identifier for the time being (ie. __stringifier, __namedgetter, etc.)

@jdm
Copy link
Copy Markdown
Member Author

jdm commented Jul 15, 2016

@bors-servo: r=Ms2ger

@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Jul 15, 2016

📌 Commit 052c018 has been approved by Ms2ger

@highfive highfive assigned Ms2ger and unassigned metajack Jul 15, 2016
@highfive highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Jul 15, 2016
@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Jul 15, 2016

⌛ Testing commit 052c018 with merge 251940e...

@highfive highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jul 15, 2016
bors-servo pushed a commit that referenced this pull request Jul 15, 2016
Auto merge of #12451 - jdm:generate-dom-apis, r=Ms2ger
251940e 
Generate a list of supported DOM APIs from parsed WebIDLs.

Supplement the existing list of supported CSS properties with an equivalent list of DOM APIs.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because automatic generated documentation

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12451)
<!-- Reviewable:end -->
@jdm
Copy link
Copy Markdown
Member Author

jdm commented Jul 15, 2016

@bors-servo: r-

@jdm jdm force-pushed the generate-dom-apis branch from 052c018 to 3c2435a Compare July 15, 2016 22:13
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Jul 15, 2016
@jdm
Copy link
Copy Markdown
Member Author

jdm commented Jul 15, 2016

@bors-servo: r=Ms2ger

@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Jul 15, 2016

📌 Commit 3c2435a has been approved by Ms2ger

@highfive highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Jul 15, 2016
@highfive highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jul 15, 2016
@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Jul 15, 2016

⌛ Testing commit 3c2435a with merge 73ad0b9...

bors-servo pushed a commit that referenced this pull request Jul 15, 2016
Auto merge of #12451 - jdm:generate-dom-apis, r=Ms2ger
73ad0b9 
Generate a list of supported DOM APIs from parsed WebIDLs.

Supplement the existing list of supported CSS properties with an equivalent list of DOM APIs.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because automatic generated documentation

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12451)
<!-- Reviewable:end -->
@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Jul 15, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows

@bors-servo bors-servo merged commit 3c2435a into servo:master Jul 15, 2016
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jul 15, 2016
@bors-servo bors-servo mentioned this pull request Jul 15, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Ms2ger Ms2ger

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jdm @highfive @Ms2ger @bors-servo @aneeshusa @metajack @pcwalton