Update heartbeats-simple to 0.3.0#11785
Merged
bors-servo merged 1 commit intoservo:masterfrom Jun 20, 2016
Merged
Conversation
|
Heads up! This PR modifies the following files:
|
highfive
added
the
S-awaiting-review
Collaborator
|
r=me but I'm pretty sure this needs more Cargo.lock changes. Reviewed 4 of 4 files at r1. Comments from Reviewable |
Collaborator
|
As in, I would expect ports/cef/Cargo.lock to need updating as well at a minimum. Review status: Comments from Reviewable |
all files reviewed at latest revision, all discussions resolved, all commit checks successful.
connorimes
force-pushed
the
update-hbs-0.3.0
branch
from
730d06e to
101aa0d
Compare
Contributor
Author
|
You are correct, thank you. |
Member
|
@bors-servo: r=metajack |
Contributor
|
📌 Commit 101aa0d has been approved by |
highfive
added
S-awaiting-merge
Contributor
bors-servo
pushed a commit
that referenced
this pull request
Jun 20, 2016
Update heartbeats-simple to 0.3.0 Updated heartbeats-simple dependency for native changes: -Collapse libraries into one. -Remove overriding of some default CMake behavior. -Windows compatibility with compiler flags, locking, and sleeping in example (thanks Jack Moffitt and Vladimir Vukicevic). --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because it's just a dependency update <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11785) <!-- Reviewable:end -->
Contributor
|
💔 Test failed - linux-rel |
highfive
added
S-tests-failed
Contributor
bors-servo
pushed a commit
that referenced
this pull request
Jun 20, 2016
Update heartbeats-simple to 0.3.0 Updated heartbeats-simple dependency for native changes: -Collapse libraries into one. -Remove overriding of some default CMake behavior. -Windows compatibility with compiler flags, locking, and sleeping in example (thanks Jack Moffitt and Vladimir Vukicevic). --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because it's just a dependency update <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11785) <!-- Reviewable:end -->
highfive
added
S-awaiting-merge
Contributor
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows |
highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated heartbeats-simple dependency for native changes:
-Collapse libraries into one.
-Remove overriding of some default CMake behavior.
-Windows compatibility with compiler flags, locking, and sleeping in example (thanks Jack Moffitt and Vladimir Vukicevic).
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is