Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify TOML syntax #10857

Merged
merged 1 commit into from
Apr 26, 2016
Merged

Simplify TOML syntax #10857

merged 1 commit into from
Apr 26, 2016

Conversation

SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented Apr 26, 2016


This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @bholley: components/style/Cargo.toml
  • @jgraham: components/webdriver_server/Cargo.toml
  • @KiChjang: components/script/Cargo.toml, components/net/Cargo.toml, components/net_traits/Cargo.toml, components/net_traits/Cargo.toml, components/script_traits/Cargo.toml, components/script_traits/Cargo.toml

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Apr 26, 2016
@nox
Copy link
Contributor

nox commented Apr 26, 2016

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit fe88f00 has been approved by nox

@nox nox assigned nox and unassigned mbrubeck Apr 26, 2016
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Apr 26, 2016
* Sections like `[dependencies.foo]` can be entries in a `[dependencies]`
  section with the `{key = value}` syntax.
* Per-target dependencies can be expressed with more general `cfg(…)`
  conditions instead of exact target triples:
  rust-lang/cargo#2328
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Apr 26, 2016
@SimonSapin
Copy link
Member Author

SimonSapin commented Apr 26, 2016

@bors-servo r=nox

Fixed a line length to make tidy happy.

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Apr 26, 2016
@bors-servo
Copy link
Contributor

💡 This pull request was already approved, no need to approve it again.

  • There's another pull request that is currently being tested, blocking this pull request: Update rustc. #10847

@bors-servo
Copy link
Contributor

📌 Commit 83b3ebf has been approved by nox

@bors-servo
Copy link
Contributor

⌛ Testing commit 83b3ebf with merge 2729864...

bors-servo pushed a commit that referenced this pull request Apr 26, 2016
Simplify TOML syntax

* Sections like `[dependencies.foo]` can be entries in a `[dependencies]` section with the `{key = value}` syntax.
* Per-target dependencies can be expressed with more general `cfg(…)` conditions instead of exact target triples: rust-lang/cargo#2328

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10857)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt

@bors-servo bors-servo merged commit 83b3ebf into master Apr 26, 2016
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 26, 2016
@SimonSapin SimonSapin deleted the toml branch April 26, 2016 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants