Skip to content

Removed sources of panic from piepline.rs.#10423

Merged
bors-servo merged 1 commit intoservo:masterfrom
asajeffrey:constellation-pipeline-hardening
Apr 8, 2016
Merged

Removed sources of panic from piepline.rs.#10423
bors-servo merged 1 commit intoservo:masterfrom
asajeffrey:constellation-pipeline-hardening

Conversation

@asajeffrey
Copy link
Copy Markdown
Contributor

@asajeffrey asajeffrey commented Apr 5, 2016

Fixes #10422.

This change is Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Apr 5, 2016
@asajeffrey asajeffrey added A-constellation Involves the constellation I-panic Servo encounters a panic. labels Apr 5, 2016
@emilio
Copy link
Copy Markdown
Member

emilio commented Apr 5, 2016

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

components/compositing/pipeline.rs, line 135 [r1] (raw file):
nit: "Pipeline layout"

Comments from Reviewable

@KiChjang KiChjang added the S-needs-rebase There are merge conflict errors. label Apr 5, 2016
@asajeffrey
Copy link
Copy Markdown
Contributor Author

asajeffrey commented Apr 5, 2016

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

components/compositing/pipeline.rs, line 135 [r1] (raw file):
Done.

Comments from Reviewable

@jdm jdm mentioned this pull request Apr 7, 2016
Merged
@ghost
Copy link
Copy Markdown

ghost commented Apr 7, 2016

@bors-servo r=emilio

@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Apr 7, 2016

📌 Commit 0e6ff74 has been approved by emilio

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. S-needs-rebase There are merge conflict errors. labels Apr 7, 2016
@jdm
Copy link
Copy Markdown
Member

jdm commented Apr 7, 2016

@bors-servo: r-
I'd prefer to see this squashed first.

@jdm jdm added S-needs-squash Some (or all) of the commits in the PR should be combined. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Apr 7, 2016
@ghost
Copy link
Copy Markdown

ghost commented Apr 7, 2016

Oops, sorry, didn't notice :)

@asajeffrey asajeffrey force-pushed the constellation-pipeline-hardening branch from 0e6ff74 to 01b6e4a Compare April 8, 2016 00:45
@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Apr 8, 2016
@asajeffrey
Copy link
Copy Markdown
Contributor Author

asajeffrey commented Apr 8, 2016

Squashed.

@asajeffrey asajeffrey removed the S-needs-squash Some (or all) of the commits in the PR should be combined. label Apr 8, 2016
@emilio
Copy link
Copy Markdown
Member

emilio commented Apr 8, 2016

@bors-servo: r=emilio,jdm

@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Apr 8, 2016

📌 Commit 01b6e4a has been approved by emilio,jdm

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Apr 8, 2016
@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Apr 8, 2016

⌛ Testing commit 01b6e4a with merge bcac1a3...

bors-servo pushed a commit that referenced this pull request Apr 8, 2016
Auto merge of #10423 - asajeffrey:constellation-pipeline-hardening, r…
bcac1a3 
…=emilio,jdm

Removed sources of panic from piepline.rs.

Fixes #10422.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10423)
<!-- Reviewable:end -->
@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Apr 8, 2016

💔 Test failed - linux-rel

@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 8, 2016
@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Apr 8, 2016
@asajeffrey
Copy link
Copy Markdown
Contributor Author

asajeffrey commented Apr 8, 2016

@bors-servo: retry

@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Apr 8, 2016

⚡ Previous build results for android, arm32, arm64, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel...

@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Apr 8, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt

@bors-servo bors-servo merged commit 01b6e4a into servo:master Apr 8, 2016
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 8, 2016
@jdm jdm mentioned this pull request Apr 13, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mbrubeck mbrubeck

Labels

A-constellation Involves the constellation I-panic Servo encounters a panic. S-tests-failed The changes caused existing tests to fail.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@asajeffrey @emilio @bors-servo @jdm @mbrubeck @KiChjang @highfive