-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Move error handling out of the network loader #8678
Copy link
Copy link
Closed
Labels
A-networkC-assignedThere is someone working on resolving the issueThere is someone working on resolving the issueI-refactorNo impact; the issue is one of maintainability or tidiness. Proposed solution requires refactoring.No impact; the issue is one of maintainability or tidiness. Proposed solution requires refactoring.I-wrongAn incorrect behaviour is observed.An incorrect behaviour is observed.
Metadata
Metadata
Assignees
Labels
A-networkC-assignedThere is someone working on resolving the issueThere is someone working on resolving the issueI-refactorNo impact; the issue is one of maintainability or tidiness. Proposed solution requires refactoring.No impact; the issue is one of maintainability or tidiness. Proposed solution requires refactoring.I-wrongAn incorrect behaviour is observed.An incorrect behaviour is observed.
There are a couple steps here:
Resultthat network listeners receive with the LoadError type fromhttp_loader.rsload_for_consumerto the network receiver instead of sending a stringservohtmlparser.rs)headers_availabletake aResult<Metadata, LoadError>value to reflect the possibility of early errors (such as SSL validation failure)