-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Convert structuredclone::write to take &mut JSContext #42347
Copy link
Copy link
Open
Labels
A-content/scriptRelated to the script threadRelated to the script threadE-less-complexStraightforward. Recommended for a new contributor.Straightforward. Recommended for a new contributor.good first issueNewcomer-friendly issues.Newcomer-friendly issues.
Description
As part of #40600 we need to replace structuredclone::write SafeJSContext usage with &mut JSContext.
Before that we must first convert all callers to accept &mut JSContext and start propagating it:
- script: use
&mut JSContextinside workersPostMessageapi #42342 -
WorkerGlobalScope::StructuredCloneandWindow::StructuredClone - Script: Use
&mut JSContextinBroadcastChannel::PostMessage#42417 -
MessagePort::PostMessage - script: use
&mut JSContextinWindow::PostMessage#42370 -
History::PushStateandHistory::ReplaceState -
DissimilarOriginWindowMethods::PostMessage
To avoid work duplication, please leave a comment with the chosen task.
For each interface you need to update its entry inside Binding.conf, you can take cues from #42342 and this guide.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-content/scriptRelated to the script threadRelated to the script threadE-less-complexStraightforward. Recommended for a new contributor.Straightforward. Recommended for a new contributor.good first issueNewcomer-friendly issues.Newcomer-friendly issues.