Skip to content

No code should be marked expect(dead_code) without configuration qualifiers #40882

@mrobinson

Description

@mrobinson

When code it marked as expect(dead_code) one of two things is typically true:

  1. The code is unused, in which case it should be removed.
  2. The code is used but in certain compilation configurations in which case expect will produce a compiler warning when the code is actually used. These should be marked as allow or expect with appropriate cfg modifiers.

The exception is when code is unused only temporarily, but these cases should be very few and be addressed in the short term. I do not think we should keep marking code as expect(dead_code).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions