-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
RemovableDomEventListener contains a Trusted member #40631
Copy link
Copy link
Closed
Labels
A-content/domInteracting with the DOM from web contentInteracting with the DOM from web contentE-less-complexStraightforward. Recommended for a new contributor.Straightforward. Recommended for a new contributor.I-cleanupNo impact; the issue is one of maintainability or tidiness.No impact; the issue is one of maintainability or tidiness.
Description
Trusted<T> is intended to be used as a handle inside of async tasks or inter-thread operations. I see no evidence that the RemovableDomEventListener type is used for either of those; we should be able to store a Dom<EventTarget> value instead and add #[cfg_attr(crown, crown::unrooted_must_root_lint::must_root)] to the struct to allow ./mach build --use-crown to succeed.
There should be no difference in behaviour when running ./mach test-wpt tests/wpt/tests/dom/abort.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-content/domInteracting with the DOM from web contentInteracting with the DOM from web contentE-less-complexStraightforward. Recommended for a new contributor.Straightforward. Recommended for a new contributor.I-cleanupNo impact; the issue is one of maintainability or tidiness.No impact; the issue is one of maintainability or tidiness.