-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
HTMLMediaElement::Seekable needs a CanGc argument #39944
Copy link
Copy link
Closed
Labels
A-content/domInteracting with the DOM from web contentInteracting with the DOM from web contentE-less-complexStraightforward. Recommended for a new contributor.Straightforward. Recommended for a new contributor.I-cleanupNo impact; the issue is one of maintainability or tidiness.No impact; the issue is one of maintainability or tidiness.
Description
Instead of using CanGc::note() in
| TimeRanges::new(self.global().as_window(), seekable, CanGc::note()) |
| 'canGc': ['Load', 'Pause', 'Play', 'SetSrcObject', 'SetCrossOrigin'], |
This matters because it's called from
| let seekable = self.Seekable(); |
self.seek(..) within a borrow_mut(), which can trigger a panic if a GC occurs. We need to chain the CanGc arguments as far up the stack as possible!
No need to run any tests; if it compiles, that's good enough for a PR.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-content/domInteracting with the DOM from web contentInteracting with the DOM from web contentE-less-complexStraightforward. Recommended for a new contributor.Straightforward. Recommended for a new contributor.I-cleanupNo impact; the issue is one of maintainability or tidiness.No impact; the issue is one of maintainability or tidiness.