-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Streams: rationalize management of cross realm transforms #37084
Copy link
Copy link
Closed
Labels
A-content/scriptRelated to the script threadRelated to the script threadE-less-complexStraightforward. Recommended for a new contributor.Straightforward. Recommended for a new contributor.
Description
Following #36977, the below note can be addressed:
servo/components/script/dom/globalscope.rs
Line 461 in c37d557
| /// Note: it may seem strange to use a pair of options, versus for example an enum. |
by merging the two fields into one:
cross_realm_transform: Option<CrossRealmTransform>,
Where CrossRealmTransform would be defined as:
#[derive(Clone, JSTraceable, MallocSizeOf)]
enum CrossRealmTransform {
Readable(CrossRealmTransformReadable),
Writable(CrossRealmTransformWritable),
}
and where fixing the code using those concepts should be obvious.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-content/scriptRelated to the script threadRelated to the script threadE-less-complexStraightforward. Recommended for a new contributor.Straightforward. Recommended for a new contributor.