-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Streams step calls clean-up #36906
Copy link
Copy link
Open
Labels
A-content/scriptRelated to the script threadRelated to the script threadB-metaThis issue tracks the status of multiple, related pieces of workThis issue tracks the status of multiple, related pieces of workE-less-complexStraightforward. Recommended for a new contributor.Straightforward. Recommended for a new contributor.
Metadata
Metadata
Assignees
Labels
A-content/scriptRelated to the script threadRelated to the script threadB-metaThis issue tracks the status of multiple, related pieces of workThis issue tracks the status of multiple, related pieces of workE-less-complexStraightforward. Recommended for a new contributor.Straightforward. Recommended for a new contributor.
The streams spec follows a calling convention where
!meansunwrap(or just call a function that does not return a result) and?meansresult?. We haven't followed this consistently, so it would be good to go over our implementations and try to allign with the spec.How to do it:
interfaceIDL at https://streams.spec.whatwg.org/#idl-index, for exampleReadableStreamcancel! [IsReadableStreamLocked](https://streams.spec.whatwg.org/#is-readable-stream-locked)([this](https://webidl.spec.whatwg.org/#this))mach test-wpt /streams/, the goal being not breaking anything. If anything breaks, please open an issue for it.Note this can be done in a loop, I suggest one fix per PR.
Our implementations of a public member can be found by searching in the code for the spec link such as https://streams.spec.whatwg.org/#rs-cancel