Skip to content

NetworkError::Internal should use an enum instead of a string #36434

Closed
#36599
Closed
NetworkError::Internal should use an enum instead of a string#36434
#36599
Labels
A-networkE-candidate-for-mentoring
@jdm

Description

@jdm
jdm
opened on Apr 10, 2025

Code like

servo/components/script/dom/eventsource.rs

Lines 362 to 365 in a0730d7

// The spec advises failing here if reconnecting would be
// "futile", with no more specific advice; WPT tests
// consider a non-http(s) scheme to be futile.
match self.event_source.root().url.scheme() {
would benefit from our network errors having a reliable structure (which would allow us to implement helper methods like is_permanent_failure), rather than simply containing a user-readable string. We could move the strings to a Debug implementation on the enum instead.

servo/components/shared/net/lib.rs

Lines 912 to 913 in a0730d7

/// Could be any of the internal errors, like unsupported scheme, connection errors, etc.
Internal(String),

However, code like

servo/components/shared/net/lib.rs

Lines 926 to 932 in a0730d7

_ => NetworkError::Internal(error_string),
}
}
pub fn from_http_error(error: &HttpError) -> Self {
NetworkError::Internal(error.to_string())
}
makes this task more challenging than it first appears. I suppose it's still possible to have a catch-all variant that only contains a string.

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-networkE-candidate-for-mentoring

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions