-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Media controls are not included in layout #31414
Copy link
Copy link
Closed
Labels
A-content/mediaA-layout/2020https://github.com/servo/servo/wiki/Layout-2020https://github.com/servo/servo/wiki/Layout-2020
Description
With #31412 applied, open https://au.gmented.com/p/video/test.html. With --legacy-layout there are media controls that appear. When using layout 2020, they do not appear. These controls rely on a special shadow host setup in the legacy layout implementation (
servo/components/layout/construct.rs
Lines 707 to 709 in 4849ba9
| let is_media_element_with_widget = node.type_id() == | |
| Some(LayoutNodeType::Element(LayoutElementType::HTMLMediaElement)) && | |
| node.as_element().unwrap().is_shadow_host(); |
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-content/mediaA-layout/2020https://github.com/servo/servo/wiki/Layout-2020https://github.com/servo/servo/wiki/Layout-2020