Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermittent crash in /css/css-values/vh_not_refreshing_on_chrome.html #23385

Closed
jdm opened this issue May 14, 2019 · 0 comments · Fixed by #34626
Closed

Intermittent crash in /css/css-values/vh_not_refreshing_on_chrome.html #23385

jdm opened this issue May 14, 2019 · 0 comments · Fixed by #34626
Labels
I-intermittent Problem reproduces intermittently.

Comments

@jdm
Copy link
Member

jdm commented May 14, 2019

  │ [2019-05-14T15:37:53Z INFO  gfx::font_cache_thread] FontList: Found font family with name=arial
  │ [2019-05-14T15:37:53Z INFO  gfx::platform::macos::font] Font metrics (@13 pt): FontMetrics { underline_size: 1.2666666666666666px, underline_offset: -1.8333333333333333px, strikeout_size: 0px, strikeout_offset: 0px, leading: 0.5666666666666667px, x_height: 6.033333333333333px, em_size: 13px, ascent: 10.533333333333333px, descent: 2.466666666666667px, max_advance: 46.18333333333333px, average_advance: 7.233333333333333px, line_gap: 15px }
  │ Failed to create IPC channel!: Custom { kind: Other, error: StringError("No room in IPC name space for another right.") } (thread Constellation, at src/libcore/result.rs:999)
  │ Failed to read dyld info for process 75952 (268451842)
  │ Failed to read dyld info for process 75952 (268451842)
  │ Failed to read dyld info for process 75952 (268451842)
  │ Failed to read dyld info for process 75952 (268451842)
  │ Failed to read dyld info for process 75952 (268451842)
  │ Stack trace
  │ stack backtrace:
  │    0:        0x1122dc3ce - backtrace::backtrace::trace::hd2a2b43b59c4b3be
  │    1:        0x1122db46c - <backtrace::capture::Backtrace as core::default::Default>::default::h874203e5f4a054b4
  │    2:        0x10f6764f5 - servo::install_crash_handler::handler::h24316eeb2d41751e
  │    3:     0x7fff58af7f59 - _sigtramp
  └    4:     0x7fff58b01183 - _pthread_wqthread
@jdm jdm added the I-intermittent Problem reproduces intermittently. label May 14, 2019
mrobinson added a commit to mrobinson/servo that referenced this issue Dec 15, 2024
This test manually animates the height of an `<iframe>` that has content
which uses the `vh` unit. Each tick of the animation changes the height
by one pixel. Inside the `<iframe>` the element using `vh` units has a
transition applied, so every manual tick of the animation triggers a new
transition. The causes a pretty slow test execution.

This change improves `vh_not_refreshing_on_chrome.html` to remove
flakiness by making the test wait to start until after the `<iframe>` has
loaded and to increase the `<iframe>` height by 10 pixels instead of 1
when doing the manual animation. These changes make the test faster and
much less flaky in Servo.

It still times out, but that will be fixed in an upcoming change to
increase the consistency of `<iframe>` sizing.

In addition, the test is reformated a bit removing extraneous whitespace
and renamed to follow WPT naming conventions.

Fixes servo#23385.
Fixes servo#15570.

Signed-off-by: Martin Robinson <[email protected]>
mrobinson added a commit to mrobinson/servo that referenced this issue Dec 16, 2024
This test manually animates the height of an `<iframe>` that has content
which uses the `vh` unit. Each tick of the animation changes the height
by one pixel. Inside the `<iframe>` the element using `vh` units has a
transition applied, so every manual tick of the animation triggers a new
transition. The causes a pretty slow test execution.

This change improves `vh_not_refreshing_on_chrome.html` to remove
flakiness by making the test wait to start until after the `<iframe>` has
loaded and to increase the `<iframe>` height by 10 pixels instead of 1
when doing the manual animation. These changes make the test faster and
much less flaky in Servo.

It still times out, but that will be fixed in an upcoming change to
increase the consistency of `<iframe>` sizing.

In addition, the test is reformated a bit removing extraneous whitespace
and renamed to follow WPT naming conventions.

Fixes servo#23385.
Fixes servo#15570.

Signed-off-by: Martin Robinson <[email protected]>
mrobinson added a commit to mrobinson/servo that referenced this issue Dec 16, 2024
This test manually animates the height of an `<iframe>` that has content
which uses the `vh` unit. Each tick of the animation changes the height
by one pixel. Inside the `<iframe>` the element using `vh` units has a
transition applied, so every manual tick of the animation triggers a new
transition. The causes a pretty slow test execution.

This change improves `vh_not_refreshing_on_chrome.html` to remove
flakiness by making the test wait to start until after the `<iframe>` has
loaded and to increase the `<iframe>` height by 10 pixels instead of 1
when doing the manual animation. These changes make the test faster and
much less flaky in Servo.

It still times out, but that will be fixed in an upcoming change to
increase the consistency of `<iframe>` sizing.

In addition, the test is reformated a bit removing extraneous whitespace
and renamed to follow WPT naming conventions.

Fixes servo#23385.
Fixes servo#15570.

Signed-off-by: Martin Robinson <[email protected]>
mrobinson added a commit to mrobinson/servo that referenced this issue Dec 16, 2024
This test manually animates the height of an `<iframe>` that has content
which uses the `vh` unit. Each tick of the animation changes the height
by one pixel. Inside the `<iframe>` the element using `vh` units has a
transition applied, so every manual tick of the animation triggers a new
transition. The causes a pretty slow test execution.

This change improves `vh_not_refreshing_on_chrome.html` to remove
flakiness by making the test wait to start until after the `<iframe>` has
loaded and to increase the `<iframe>` height by 10 pixels instead of 1
when doing the manual animation. These changes make the test faster and
much less flaky in Servo.

It still times out, but that will be fixed in an upcoming change to
increase the consistency of `<iframe>` sizing.

In addition, the test is reformated a bit removing extraneous whitespace
and renamed to follow WPT naming conventions.

Fixes servo#23385.
Fixes servo#15570.

Signed-off-by: Martin Robinson <[email protected]>
mrobinson added a commit to mrobinson/servo that referenced this issue Dec 16, 2024
This test manually animates the height of an `<iframe>` that has content
which uses the `vh` unit. Each tick of the animation changes the height
by one pixel. Inside the `<iframe>` the element using `vh` units has a
transition applied, so every manual tick of the animation triggers a new
transition. The causes a pretty slow test execution.

This change improves `vh_not_refreshing_on_chrome.html` to remove
flakiness by making the test wait to start until after the `<iframe>` has
loaded and to increase the `<iframe>` height by 10 pixels instead of 1
when doing the manual animation. These changes make the test faster and
much less flaky in Servo.

In addition, the test is reformated a bit removing extraneous whitespace
and renamed to follow WPT naming conventions.

Fixes servo#23385.
Fixes servo#15570.

Signed-off-by: Martin Robinson <[email protected]>
github-merge-queue bot pushed a commit that referenced this issue Dec 16, 2024
This test manually animates the height of an `<iframe>` that has content
which uses the `vh` unit. Each tick of the animation changes the height
by one pixel. Inside the `<iframe>` the element using `vh` units has a
transition applied, so every manual tick of the animation triggers a new
transition. The causes a pretty slow test execution.

This change improves `vh_not_refreshing_on_chrome.html` to remove
flakiness by making the test wait to start until after the `<iframe>` has
loaded and to increase the `<iframe>` height by 10 pixels instead of 1
when doing the manual animation. These changes make the test faster and
much less flaky in Servo.

In addition, the test is reformated a bit removing extraneous whitespace
and renamed to follow WPT naming conventions.

Fixes #23385.
Fixes #15570.

Signed-off-by: Martin Robinson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I-intermittent Problem reproduces intermittently.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant