-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intermittent crash in /css/css-values/vh_not_refreshing_on_chrome.html #23385
Labels
I-intermittent
Problem reproduces intermittently.
Comments
23 tasks
This was referenced Mar 29, 2023
This was referenced Apr 5, 2023
4 tasks
4 tasks
This was referenced May 14, 2024
This was referenced May 21, 2024
This was referenced Nov 29, 2024
Merged
This was referenced Dec 9, 2024
mrobinson
added a commit
to mrobinson/servo
that referenced
this issue
Dec 15, 2024
This test manually animates the height of an `<iframe>` that has content which uses the `vh` unit. Each tick of the animation changes the height by one pixel. Inside the `<iframe>` the element using `vh` units has a transition applied, so every manual tick of the animation triggers a new transition. The causes a pretty slow test execution. This change improves `vh_not_refreshing_on_chrome.html` to remove flakiness by making the test wait to start until after the `<iframe>` has loaded and to increase the `<iframe>` height by 10 pixels instead of 1 when doing the manual animation. These changes make the test faster and much less flaky in Servo. It still times out, but that will be fixed in an upcoming change to increase the consistency of `<iframe>` sizing. In addition, the test is reformated a bit removing extraneous whitespace and renamed to follow WPT naming conventions. Fixes servo#23385. Fixes servo#15570. Signed-off-by: Martin Robinson <[email protected]>
3 tasks
mrobinson
added a commit
to mrobinson/servo
that referenced
this issue
Dec 16, 2024
This test manually animates the height of an `<iframe>` that has content which uses the `vh` unit. Each tick of the animation changes the height by one pixel. Inside the `<iframe>` the element using `vh` units has a transition applied, so every manual tick of the animation triggers a new transition. The causes a pretty slow test execution. This change improves `vh_not_refreshing_on_chrome.html` to remove flakiness by making the test wait to start until after the `<iframe>` has loaded and to increase the `<iframe>` height by 10 pixels instead of 1 when doing the manual animation. These changes make the test faster and much less flaky in Servo. It still times out, but that will be fixed in an upcoming change to increase the consistency of `<iframe>` sizing. In addition, the test is reformated a bit removing extraneous whitespace and renamed to follow WPT naming conventions. Fixes servo#23385. Fixes servo#15570. Signed-off-by: Martin Robinson <[email protected]>
mrobinson
added a commit
to mrobinson/servo
that referenced
this issue
Dec 16, 2024
This test manually animates the height of an `<iframe>` that has content which uses the `vh` unit. Each tick of the animation changes the height by one pixel. Inside the `<iframe>` the element using `vh` units has a transition applied, so every manual tick of the animation triggers a new transition. The causes a pretty slow test execution. This change improves `vh_not_refreshing_on_chrome.html` to remove flakiness by making the test wait to start until after the `<iframe>` has loaded and to increase the `<iframe>` height by 10 pixels instead of 1 when doing the manual animation. These changes make the test faster and much less flaky in Servo. It still times out, but that will be fixed in an upcoming change to increase the consistency of `<iframe>` sizing. In addition, the test is reformated a bit removing extraneous whitespace and renamed to follow WPT naming conventions. Fixes servo#23385. Fixes servo#15570. Signed-off-by: Martin Robinson <[email protected]>
mrobinson
added a commit
to mrobinson/servo
that referenced
this issue
Dec 16, 2024
This test manually animates the height of an `<iframe>` that has content which uses the `vh` unit. Each tick of the animation changes the height by one pixel. Inside the `<iframe>` the element using `vh` units has a transition applied, so every manual tick of the animation triggers a new transition. The causes a pretty slow test execution. This change improves `vh_not_refreshing_on_chrome.html` to remove flakiness by making the test wait to start until after the `<iframe>` has loaded and to increase the `<iframe>` height by 10 pixels instead of 1 when doing the manual animation. These changes make the test faster and much less flaky in Servo. It still times out, but that will be fixed in an upcoming change to increase the consistency of `<iframe>` sizing. In addition, the test is reformated a bit removing extraneous whitespace and renamed to follow WPT naming conventions. Fixes servo#23385. Fixes servo#15570. Signed-off-by: Martin Robinson <[email protected]>
mrobinson
added a commit
to mrobinson/servo
that referenced
this issue
Dec 16, 2024
This test manually animates the height of an `<iframe>` that has content which uses the `vh` unit. Each tick of the animation changes the height by one pixel. Inside the `<iframe>` the element using `vh` units has a transition applied, so every manual tick of the animation triggers a new transition. The causes a pretty slow test execution. This change improves `vh_not_refreshing_on_chrome.html` to remove flakiness by making the test wait to start until after the `<iframe>` has loaded and to increase the `<iframe>` height by 10 pixels instead of 1 when doing the manual animation. These changes make the test faster and much less flaky in Servo. In addition, the test is reformated a bit removing extraneous whitespace and renamed to follow WPT naming conventions. Fixes servo#23385. Fixes servo#15570. Signed-off-by: Martin Robinson <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this issue
Dec 16, 2024
This test manually animates the height of an `<iframe>` that has content which uses the `vh` unit. Each tick of the animation changes the height by one pixel. Inside the `<iframe>` the element using `vh` units has a transition applied, so every manual tick of the animation triggers a new transition. The causes a pretty slow test execution. This change improves `vh_not_refreshing_on_chrome.html` to remove flakiness by making the test wait to start until after the `<iframe>` has loaded and to increase the `<iframe>` height by 10 pixels instead of 1 when doing the manual animation. These changes make the test faster and much less flaky in Servo. In addition, the test is reformated a bit removing extraneous whitespace and renamed to follow WPT naming conventions. Fixes #23385. Fixes #15570. Signed-off-by: Martin Robinson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The text was updated successfully, but these errors were encountered: