Skip to content

Too many use when using libservo #18475

@paulrouget

Description

@paulrouget

When using libservo in a third party project, all these paths expose some internal informations we don't need to know about:

use self::servo::config::servo_version;
use self::servo::servo_config::opts;
use self::servo::servo_config::resource_files::set_resources_path;
use self::servo::compositing::windowing::{MouseWindowEvent, WindowMethods, WindowEvent};
use self::servo::msg::constellation_msg::TraversalDirection;
use self::servo::servo_geometry::DeviceIndependentPixel;
use self::servo::euclid::{Point2D, ScaleFactor, Size2D, TypedPoint2D, TypedRect, TypedSize2D, TypedVector2D};
use self::servo::ipc_channel::ipc;
use self::servo::script_traits::{LoadData, MouseButton, TouchEventType};
use self::servo::style_traits::DevicePixel;
use self::servo::net_traits::net_error_list::NetError;
use self::servo::webrender_api::ScrollLocation;
use self::servo::BrowserId;
use self::servo::compositing::compositor_thread::EventLoopWaker;
use self::servo::style_traits::cursor::Cursor as ServoCursor;
use self::servo::servo_url::ServoUrl;
use self::servo::compositing::windowing::WebRenderDebugOption;
use self::servo::msg::constellation_msg::{Key, KeyModifiers, KeyState};
use self::servo::msg::constellation_msg::{SHIFT, CONTROL, ALT, SUPER};
use gleam::gl;

I'm not sure we want to expose all these intermediate path, like msg::constellation_msg, webrender_api, compositing::windowing, …

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-embeddingI-cleanupNo impact; the issue is one of maintainability or tidiness.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions