-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Pass the initial URL as an argument to Browser::new, not as a opts property #15636
Copy link
Copy link
Closed
Closed
Copy link
Labels
A-embeddingC-assignedThere is someone working on resolving the issueThere is someone working on resolving the issueC-has-open-prThere is a PR open that resolves the issueThere is a PR open that resolves the issueE-more-complexVariable effort required; may require a mentor. Recommended solution is clearly described in the issVariable effort required; may require a mentor. Recommended solution is clearly described in the iss
Description
This issue is part of an effort to improve Servo's embedding story. See https://github.com/paulrouget/servoshell/projects/2
Starting Servo from a third party application requires setting the initial URL as an option:
let mut opts = opts::default_opts();
opts.url = ServoUrl::parse(url).ok();
opts::set_defaults(opts);
I would expect to be able to do that instead:
servo::Browser::new(window, url);
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-embeddingC-assignedThere is someone working on resolving the issueThere is someone working on resolving the issueC-has-open-prThere is a PR open that resolves the issueThere is a PR open that resolves the issueE-more-complexVariable effort required; may require a mentor. Recommended solution is clearly described in the issVariable effort required; may require a mentor. Recommended solution is clearly described in the iss