-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Promise rooting is not sound #15085
Copy link
Copy link
Closed
Labels
A-content/bindingsThe DOM bindingsThe DOM bindingsI-crashNo impact; the issue is one of maintainability or tidiness.No impact; the issue is one of maintainability or tidiness.
Description
The second commit in #15080 exposes a crash that involves a TrustedPromise value that has been garbage collected by the time we try to turn it into a stack root once more. The backtrace shows a nursery GC occurring, which means that our trace hooks don't get called. The promise object is nursery-allocated, I guess, which would explain why it's GCed during the minor collection.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-content/bindingsThe DOM bindingsThe DOM bindingsI-crashNo impact; the issue is one of maintainability or tidiness.No impact; the issue is one of maintainability or tidiness.