Auto merge of #29664 - mrobinson:fix-animation-flakiness, r=<try>

bors-servo · web-flow · commit 8781b5a4fd3c · 2023-04-25T13:16:35.000+02:00
Try to fix flakiness in animation tests

Update all animations before forcing a reflow.

&lt;!-- Please describe your changes on the following line: --&gt;

---
&lt;!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --&gt;
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

&lt;!-- Either: --&gt;
- [x] There are tests for these changes

&lt;!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--&gt;

&lt;!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --&gt;
diff --git a/components/script/dom/window.rs b/components/script/dom/window.rs
@@ -1874,6 +1874,9 @@ impl Window {
             document.flush_dirty_webgl_canvases();
         }
 
+        document.update_animation_timeline();
+        document.animations().mark_animating_nodes_as_dirty();
+
         let pending_restyles = document.drain_pending_restyles();
 
         let dirty_root = document
diff --git a/etc/ci/report_aggregated_expected_results.py b/etc/ci/report_aggregated_expected_results.py
@@ -34,14 +34,14 @@ def __init__(self, title: str, body: str, children: list[Item]):
         self.children = children
 
     @classmethod
-    def from_result(cls, result: dict, title_key: str = "path", title_prefix: str = "", print_stack=True):
+    def from_result(cls, result: dict, title: Optional[str], print_stack=True):
         expected = result["expected"]
         actual = result["actual"]
-        title = result[title_key]
+        title = title if title else result["path"]
         if expected != actual:
-            title = f"{actual} [expected {expected}] {title_prefix}{title}"
+            title = f"{actual} [expected {expected}] {title}"
         else:
-            title = f"{actual} {title_prefix}{title}"
+            title = f"{actual} {title}"
 
         issue_url = "http://github.com/servo/servo/issues/"
         if "issues" in result and result["issues"]:
@@ -54,7 +54,10 @@ def from_result(cls, result: dict, title_key: str = "path", title_prefix: str =
 
         subtest_results = result.get("unexpected_subtest_results", [])
         children = [
-            cls.from_result(subtest_result, "subtest", "subtest: ", False)
+            cls.from_result(
+                subtest_result,
+                f"subtest: {subtest_result['subtest']} {subtest_result.get('message', '')}",
+                False)
             for subtest_result in subtest_results
         ]
         return cls(title, body, children)
diff --git a/python/wpt/grouping_formatter.py b/python/wpt/grouping_formatter.py
@@ -93,7 +93,11 @@ def to_lines(result: Any[UnexpectedSubtestResult, UnexpectedResult], print_stack
 
         # Test names sometimes contain control characters, which we want
         # to be printed in their raw form, and not their interpreted form.
-        first_line += f" {result.path.encode('unicode-escape').decode('utf-8')}"
+        if isinstance(result, UnexpectedSubtestResult):
+            title = result.subtest
+        else:
+            title = result.path
+        first_line += f" {title.encode('unicode-escape').decode('utf-8')}"
 
         if isinstance(result, UnexpectedResult) and result.issues:
             first_line += f" ({', '.join([f'#{bug}' for bug in result.issues])})"
diff --git a/tests/wpt/metadata/css/css-transitions/animations/text-shadow-interpolation.html.ini b/tests/wpt/metadata/css/css-transitions/animations/text-shadow-interpolation.html.ini
@@ -127,3 +127,147 @@
 
   [Web Animations: property <text-shadow> from [black 0px 0px 0px\] to [black 1px 1px 1px\] at (1.5) should be [rgb(0, 0, 0) 1.5px 1.5px 1.5px\]]
     expected: FAIL
+
+  [CSS Transitions: property <text-shadow> from neutral to [green 20px 20px 20px\] at (0.3) should be [rgb(179, 154, 0) 13px 27px 13px\]]
+    expected: FAIL
+
+  [CSS Transitions: property <text-shadow> from neutral to [green 20px 20px 20px\] at (1.5) should be [rgb(0, 110, 0) 25px 15px 25px\]]
+    expected: FAIL
+
+  [CSS Transitions with transition: all: property <text-shadow> from neutral to [green 20px 20px 20px\] at (-0.3) should be [rgb(255, 176, 0) 7px 33px 7px\]]
+    expected: FAIL
+
+  [CSS Transitions with transition: all: property <text-shadow> from neutral to [green 20px 20px 20px\] at (0.3) should be [rgb(179, 154, 0) 13px 27px 13px\]]
+    expected: FAIL
+
+  [CSS Transitions with transition: all: property <text-shadow> from neutral to [green 20px 20px 20px\] at (0.6) should be [rgb(102, 143, 0) 16px 24px 16px\]]
+    expected: FAIL
+
+  [CSS Transitions with transition: all: property <text-shadow> from neutral to [green 20px 20px 20px\] at (1.5) should be [rgb(0, 110, 0) 25px 15px 25px\]]
+    expected: FAIL
+
+  [CSS Animations: property <text-shadow> from neutral to [green 20px 20px 20px\] at (-0.3) should be [rgb(255, 176, 0) 7px 33px 7px\]]
+    expected: FAIL
+
+  [CSS Animations: property <text-shadow> from neutral to [green 20px 20px 20px\] at (0.3) should be [rgb(179, 154, 0) 13px 27px 13px\]]
+    expected: FAIL
+
+  [CSS Animations: property <text-shadow> from neutral to [green 20px 20px 20px\] at (0.6) should be [rgb(102, 143, 0) 16px 24px 16px\]]
+    expected: FAIL
+
+  [CSS Animations: property <text-shadow> from neutral to [green 20px 20px 20px\] at (1.5) should be [rgb(0, 110, 0) 25px 15px 25px\]]
+    expected: FAIL
+
+  [CSS Transitions: property <text-shadow> from [initial\] to [green 20px 20px 20px\] at (0.6) should be [rgba(0, 128, 0, 0.6) 12px 12px 12px\]]
+    expected: FAIL
+
+  [CSS Transitions: property <text-shadow> from [initial\] to [green 20px 20px 20px\] at (1.5) should be [rgb(0, 192, 0) 30px 30px 30px\]]
+    expected: FAIL
+
+  [CSS Transitions with transition: all: property <text-shadow> from [initial\] to [green 20px 20px 20px\] at (-0.3) should be [rgba(0, 0, 0, 0) -6px -6px 0px\]]
+    expected: FAIL
+
+  [CSS Transitions with transition: all: property <text-shadow> from [initial\] to [green 20px 20px 20px\] at (0.3) should be [rgba(0, 128, 0, 0.3) 6px 6px 6px\]]
+    expected: FAIL
+
+  [CSS Transitions with transition: all: property <text-shadow> from [initial\] to [green 20px 20px 20px\] at (0.6) should be [rgba(0, 128, 0, 0.6) 12px 12px 12px\]]
+    expected: FAIL
+
+  [CSS Transitions with transition: all: property <text-shadow> from [initial\] to [green 20px 20px 20px\] at (1.5) should be [rgb(0, 192, 0) 30px 30px 30px\]]
+    expected: FAIL
+
+  [CSS Animations: property <text-shadow> from [initial\] to [green 20px 20px 20px\] at (-0.3) should be [rgba(0, 0, 0, 0) -6px -6px 0px\]]
+    expected: FAIL
+
+  [CSS Animations: property <text-shadow> from [initial\] to [green 20px 20px 20px\] at (0.3) should be [rgba(0, 128, 0, 0.3) 6px 6px 6px\]]
+    expected: FAIL
+
+  [CSS Animations: property <text-shadow> from [initial\] to [green 20px 20px 20px\] at (0.6) should be [rgba(0, 128, 0, 0.6) 12px 12px 12px\]]
+    expected: FAIL
+
+  [CSS Animations: property <text-shadow> from [initial\] to [green 20px 20px 20px\] at (1.5) should be [rgb(0, 192, 0) 30px 30px 30px\]]
+    expected: FAIL
+
+  [CSS Transitions: property <text-shadow> from [inherit\] to [green 20px 20px 20px\] at (0.3) should be [rgb(179, 154, 0) 27px 13px 27px\]]
+    expected: FAIL
+
+  [CSS Transitions: property <text-shadow> from [inherit\] to [green 20px 20px 20px\] at (1.5) should be [rgb(0, 110, 0) 15px 25px 15px\]]
+    expected: FAIL
+
+  [CSS Transitions with transition: all: property <text-shadow> from [inherit\] to [green 20px 20px 20px\] at (0.3) should be [rgb(179, 154, 0) 27px 13px 27px\]]
+    expected: FAIL
+
+  [CSS Transitions with transition: all: property <text-shadow> from [inherit\] to [green 20px 20px 20px\] at (1.5) should be [rgb(0, 110, 0) 15px 25px 15px\]]
+    expected: FAIL
+
+  [CSS Animations: property <text-shadow> from [inherit\] to [green 20px 20px 20px\] at (-0.3) should be [rgb(255, 176, 0) 33px 7px 33px\]]
+    expected: FAIL
+
+  [CSS Animations: property <text-shadow> from [inherit\] to [green 20px 20px 20px\] at (0.3) should be [rgb(179, 154, 0) 27px 13px 27px\]]
+    expected: FAIL
+
+  [CSS Animations: property <text-shadow> from [inherit\] to [green 20px 20px 20px\] at (0.6) should be [rgb(102, 143, 0) 24px 16px 24px\]]
+    expected: FAIL
+
+  [CSS Animations: property <text-shadow> from [inherit\] to [green 20px 20px 20px\] at (1.5) should be [rgb(0, 110, 0) 15px 25px 15px\]]
+    expected: FAIL
+
+  [CSS Transitions: property <text-shadow> from [unset\] to [green 20px 20px 20px\] at (0.3) should be [rgb(179, 154, 0) 27px 13px 27px\]]
+    expected: FAIL
+
+  [CSS Transitions: property <text-shadow> from [unset\] to [green 20px 20px 20px\] at (1.5) should be [rgb(0, 110, 0) 15px 25px 15px\]]
+    expected: FAIL
+
+  [CSS Transitions with transition: all: property <text-shadow> from [unset\] to [green 20px 20px 20px\] at (0.3) should be [rgb(179, 154, 0) 27px 13px 27px\]]
+    expected: FAIL
+
+  [CSS Transitions with transition: all: property <text-shadow> from [unset\] to [green 20px 20px 20px\] at (0.6) should be [rgb(102, 143, 0) 24px 16px 24px\]]
+    expected: FAIL
+
+  [CSS Transitions with transition: all: property <text-shadow> from [unset\] to [green 20px 20px 20px\] at (1.5) should be [rgb(0, 110, 0) 15px 25px 15px\]]
+    expected: FAIL
+
+  [CSS Animations: property <text-shadow> from [unset\] to [green 20px 20px 20px\] at (-0.3) should be [rgb(255, 176, 0) 33px 7px 33px\]]
+    expected: FAIL
+
+  [CSS Animations: property <text-shadow> from [unset\] to [green 20px 20px 20px\] at (0.3) should be [rgb(179, 154, 0) 27px 13px 27px\]]
+    expected: FAIL
+
+  [CSS Animations: property <text-shadow> from [unset\] to [green 20px 20px 20px\] at (0.6) should be [rgb(102, 143, 0) 24px 16px 24px\]]
+    expected: FAIL
+
+  [CSS Animations: property <text-shadow> from [unset\] to [green 20px 20px 20px\] at (1.5) should be [rgb(0, 110, 0) 15px 25px 15px\]]
+    expected: FAIL
+
+  [CSS Transitions: property <text-shadow> from [black 15px 10px 5px\] to [orange -15px -10px 25px\] at (0.3) should be [rgb(77, 50, 0) 6px 4px 11px\]]
+    expected: FAIL
+
+  [CSS Transitions: property <text-shadow> from [black 15px 10px 5px\] to [orange -15px -10px 25px\] at (0.6) should be [rgb(153, 99, 0) -3px -2px 17px\]]
+    expected: FAIL
+
+  [CSS Transitions: property <text-shadow> from [black 15px 10px 5px\] to [orange -15px -10px 25px\] at (1.5) should be [rgb(255, 248, 0) -30px -20px 35px\]]
+    expected: FAIL
+
+  [CSS Transitions with transition: all: property <text-shadow> from [black 15px 10px 5px\] to [orange -15px -10px 25px\] at (-0.3) should be [rgb(0, 0, 0) 24px 16px 0px\]]
+    expected: FAIL
+
+  [CSS Transitions with transition: all: property <text-shadow> from [black 15px 10px 5px\] to [orange -15px -10px 25px\] at (0.3) should be [rgb(77, 50, 0) 6px 4px 11px\]]
+    expected: FAIL
+
+  [CSS Transitions with transition: all: property <text-shadow> from [black 15px 10px 5px\] to [orange -15px -10px 25px\] at (0.6) should be [rgb(153, 99, 0) -3px -2px 17px\]]
+    expected: FAIL
+
+  [CSS Transitions with transition: all: property <text-shadow> from [black 15px 10px 5px\] to [orange -15px -10px 25px\] at (1.5) should be [rgb(255, 248, 0) -30px -20px 35px\]]
+    expected: FAIL
+
+  [CSS Animations: property <text-shadow> from [black 15px 10px 5px\] to [orange -15px -10px 25px\] at (-0.3) should be [rgb(0, 0, 0) 24px 16px 0px\]]
+    expected: FAIL
+
+  [CSS Animations: property <text-shadow> from [black 15px 10px 5px\] to [orange -15px -10px 25px\] at (0.3) should be [rgb(77, 50, 0) 6px 4px 11px\]]
+    expected: FAIL
+
+  [CSS Animations: property <text-shadow> from [black 15px 10px 5px\] to [orange -15px -10px 25px\] at (0.6) should be [rgb(153, 99, 0) -3px -2px 17px\]]
+    expected: FAIL
+
+  [CSS Animations: property <text-shadow> from [black 15px 10px 5px\] to [orange -15px -10px 25px\] at (1.5) should be [rgb(255, 248, 0) -30px -20px 35px\]]
+    expected: FAIL
diff --git a/tests/wpt/metadata/css/css-transitions/animations/vertical-align-interpolation.html.ini b/tests/wpt/metadata/css/css-transitions/animations/vertical-align-interpolation.html.ini
@@ -223,3 +223,120 @@
 
   [CSS Transitions: property <vertical-align> from [super\] to [40%\] at (0.3) should be [super\]]
     expected: FAIL
+
+  [CSS Transitions: property <vertical-align> from neutral to [40px\] at (1.5) should be [55px\]]
+    expected: FAIL
+
+  [CSS Transitions with transition: all: property <vertical-align> from neutral to [40px\] at (-0.5) should be [-5px\]]
+    expected: FAIL
+
+  [CSS Transitions with transition: all: property <vertical-align> from neutral to [40px\] at (0.3) should be [19px\]]
+    expected: FAIL
+
+  [CSS Transitions with transition: all: property <vertical-align> from neutral to [40px\] at (0.6) should be [28px\]]
+    expected: FAIL
+
+  [CSS Transitions with transition: all: property <vertical-align> from neutral to [40px\] at (1.5) should be [55px\]]
+    expected: FAIL
+
+  [CSS Animations: property <vertical-align> from neutral to [40px\] at (-0.5) should be [-5px\]]
+    expected: FAIL
+
+  [CSS Animations: property <vertical-align> from neutral to [40px\] at (0.3) should be [19px\]]
+    expected: FAIL
+
+  [CSS Animations: property <vertical-align> from neutral to [40px\] at (0.6) should be [28px\]]
+    expected: FAIL
+
+  [CSS Animations: property <vertical-align> from neutral to [40px\] at (1.5) should be [55px\]]
+    expected: FAIL
+
+  [CSS Transitions: property <vertical-align> from [inherit\] to [40px\] at (0.3) should be [82px\]]
+    expected: FAIL
+
+  [CSS Transitions: property <vertical-align> from [inherit\] to [40px\] at (0.6) should be [64px\]]
+    expected: FAIL
+
+  [CSS Transitions: property <vertical-align> from [inherit\] to [40px\] at (1.5) should be [10px\]]
+    expected: FAIL
+
+  [CSS Transitions with transition: all: property <vertical-align> from [inherit\] to [40px\] at (-0.5) should be [130px\]]
+    expected: FAIL
+
+  [CSS Transitions with transition: all: property <vertical-align> from [inherit\] to [40px\] at (0.3) should be [82px\]]
+    expected: FAIL
+
+  [CSS Transitions with transition: all: property <vertical-align> from [inherit\] to [40px\] at (0.6) should be [64px\]]
+    expected: FAIL
+
+  [CSS Transitions with transition: all: property <vertical-align> from [inherit\] to [40px\] at (1.5) should be [10px\]]
+    expected: FAIL
+
+  [CSS Animations: property <vertical-align> from [inherit\] to [40px\] at (-0.5) should be [130px\]]
+    expected: FAIL
+
+  [CSS Animations: property <vertical-align> from [inherit\] to [40px\] at (0.3) should be [82px\]]
+    expected: FAIL
+
+  [CSS Animations: property <vertical-align> from [inherit\] to [40px\] at (0.6) should be [64px\]]
+    expected: FAIL
+
+  [CSS Animations: property <vertical-align> from [inherit\] to [40px\] at (1.5) should be [10px\]]
+    expected: FAIL
+
+  [CSS Transitions: property <vertical-align> from [0px\] to [100px\] at (-0.5) should be [-50px\]]
+    expected: FAIL
+
+  [CSS Transitions: property <vertical-align> from [0px\] to [100px\] at (0.3) should be [30px\]]
+    expected: FAIL
+
+  [CSS Transitions: property <vertical-align> from [0px\] to [100px\] at (0.6) should be [60px\]]
+    expected: FAIL
+
+  [CSS Transitions: property <vertical-align> from [0px\] to [100px\] at (1.5) should be [150px\]]
+    expected: FAIL
+
+  [CSS Transitions with transition: all: property <vertical-align> from [0px\] to [100px\] at (-0.5) should be [-50px\]]
+    expected: FAIL
+
+  [CSS Transitions with transition: all: property <vertical-align> from [0px\] to [100px\] at (0.3) should be [30px\]]
+    expected: FAIL
+
+  [CSS Transitions with transition: all: property <vertical-align> from [0px\] to [100px\] at (0.6) should be [60px\]]
+    expected: FAIL
+
+  [CSS Transitions with transition: all: property <vertical-align> from [0px\] to [100px\] at (1.5) should be [150px\]]
+    expected: FAIL
+
+  [CSS Animations: property <vertical-align> from [0px\] to [100px\] at (-0.5) should be [-50px\]]
+    expected: FAIL
+
+  [CSS Animations: property <vertical-align> from [0px\] to [100px\] at (0.3) should be [30px\]]
+    expected: FAIL
+
+  [CSS Animations: property <vertical-align> from [0px\] to [100px\] at (0.6) should be [60px\]]
+    expected: FAIL
+
+  [CSS Animations: property <vertical-align> from [0px\] to [100px\] at (1.5) should be [150px\]]
+    expected: FAIL
+
+  [CSS Transitions: property <vertical-align> from [40px\] to [40%\] at (1.5) should be [calc(-20px + 60%)\]]
+    expected: FAIL
+
+  [CSS Transitions with transition: all: property <vertical-align> from [40px\] to [40%\] at (-0.5) should be [calc(60px - 20%)\]]
+    expected: FAIL
+
+  [CSS Transitions with transition: all: property <vertical-align> from [40px\] to [40%\] at (0.3) should be [calc(28px + 12%)\]]
+    expected: FAIL
+
+  [CSS Transitions with transition: all: property <vertical-align> from [40px\] to [40%\] at (1.5) should be [calc(-20px + 60%)\]]
+    expected: FAIL
+
+  [CSS Animations: property <vertical-align> from [40px\] to [40%\] at (-0.5) should be [calc(60px - 20%)\]]
+    expected: FAIL
+
+  [CSS Animations: property <vertical-align> from [40px\] to [40%\] at (0.3) should be [calc(28px + 12%)\]]
+    expected: FAIL
+
+  [CSS Animations: property <vertical-align> from [40px\] to [40%\] at (1.5) should be [calc(-20px + 60%)\]]
+    expected: FAIL
diff --git a/tests/wpt/metadata/css/css-transitions/properties-value-003.html.ini b/tests/wpt/metadata/css/css-transitions/properties-value-003.html.ini
@@ -491,3 +491,24 @@
 
   [object-view-box object-view-box(xywh) / events]
     expected: FAIL
+
+  [border-top-left-radius border-radius(px) / values]
+    expected: FAIL
+
+  [border-top-left-radius border-radius(px-px) / values]
+    expected: FAIL
+
+  [border-top-right-radius border-radius(px) / values]
+    expected: FAIL
+
+  [border-top-right-radius border-radius(px-px) / values]
+    expected: FAIL
+
+  [border-bottom-left-radius border-radius(px) / values]
+    expected: FAIL
+
+  [border-bottom-left-radius border-radius(px-px) / values]
+    expected: FAIL
+
+  [border-bottom-right-radius border-radius(px) / values]
+    expected: FAIL
diff --git a/tests/wpt/metadata/css/css-transitions/properties-value-inherit-001.html.ini b/tests/wpt/metadata/css/css-transitions/properties-value-inherit-001.html.ini
@@ -869,3 +869,48 @@
 
   [z-index integer(integer) / events]
     expected: [FAIL, PASS]
+
+  [background-color color(rgba) / values]
+    expected: FAIL
+
+  [border-top-width length(pt) / values]
+    expected: FAIL
+
+  [border-top-width length(pc) / values]
+    expected: FAIL
+
+  [border-top-width length(px) / values]
+    expected: FAIL
+
+  [border-top-width length(em) / values]
+    expected: FAIL
+
+  [border-top-width length(ex) / values]
+    expected: FAIL
+
+  [border-top-width length(mm) / values]
+    expected: FAIL
+
+  [border-top-width length(cm) / values]
+    expected: FAIL
+
+  [border-top-width length(in) / values]
+    expected: FAIL
+
+  [border-right-width length(pt) / values]
+    expected: FAIL
+
+  [border-right-width length(pc) / values]
+    expected: FAIL
+
+  [border-right-width length(px) / values]
+    expected: FAIL
+
+  [border-right-width length(em) / values]
+    expected: FAIL
+
+  [border-right-width length(ex) / values]
+    expected: FAIL
+
+  [border-right-width length(mm) / values]
+    expected: FAIL
diff --git a/tests/wpt/metadata/css/css-transitions/properties-value-inherit-002.html.ini b/tests/wpt/metadata/css/css-transitions/properties-value-inherit-002.html.ini
diff --git a/tests/wpt/metadata/css/css-transitions/properties-value-inherit-003.html.ini b/tests/wpt/metadata/css/css-transitions/properties-value-inherit-003.html.ini

Original file line number	Diff line number	Diff line change
`@@ -1874,6 +1874,9 @@ impl Window {`
`1874`	`1874`	`document.flush_dirty_webgl_canvases();`
`1875`	`1875`	`}`
`1876`	`1876`
	`1877`	`+ document.update_animation_timeline();`
	`1878`	`+ document.animations().mark_animating_nodes_as_dirty();`
	`1879`	`+`
`1877`	`1880`	`let pending_restyles = document.drain_pending_restyles();`
`1878`	`1881`
`1879`	`1882`	`let dirty_root = document`