Skip to content

Commit 727651b

Browse files
committed
Change old references of ecoal95
1 parent 1670a68 commit 727651b

File tree

6 files changed

+10
-11
lines changed

6 files changed

+10
-11
lines changed

components/canvas/webgl_paint_thread.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ impl WebGLPaintThread {
8282
CanvasMsg::Common(message) => {
8383
match message {
8484
CanvasCommonMsg::Close => break,
85-
// TODO(ecoal95): handle error nicely
85+
// TODO(emilio): handle error nicely
8686
CanvasCommonMsg::Recreate(size) => painter.recreate(size).unwrap(),
8787
}
8888
},

components/script/dom/htmlcanvaselement.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,7 @@ impl HTMLCanvasElement {
206206
CanvasData::Pixels(pixel_data)
207207
=> pixel_data.image_data.to_vec(),
208208
CanvasData::WebGL(_)
209-
// TODO(ecoal95): Not sure if WebGL canvas is required for 2d spec,
209+
// TODO(emilio): Not sure if WebGL canvas is required for 2d spec,
210210
// but I think it's not.
211211
=> return None,
212212
}

components/script/dom/webglprogram.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ impl WebGLProgram {
9696
_ => return Err(WebGLError::InvalidOperation),
9797
};
9898

99-
// TODO(ecoal95): Differentiate between same shader already assigned and other previous
99+
// TODO(emilio): Differentiate between same shader already assigned and other previous
100100
// shader.
101101
if shader_slot.get().is_some() {
102102
return Err(WebGLError::InvalidOperation);

components/script/dom/webglrenderingcontext.rs

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -610,7 +610,7 @@ impl WebGLRenderingContextMethods for WebGLRenderingContext {
610610
}
611611
}
612612

613-
// TODO(ecoal95): Probably in the future we should keep track of the
613+
// TODO(emilio): Probably in the future we should keep track of the
614614
// generated objects, either here or in the webgl thread
615615
// https://www.khronos.org/registry/webgl/specs/latest/1.0/#5.14.5
616616
fn CreateBuffer(&self) -> Option<Root<WebGLBuffer>> {
@@ -1116,8 +1116,7 @@ impl WebGLRenderingContextMethods for WebGLRenderingContext {
11161116
if texture.is_none() {
11171117
return self.webgl_error(InvalidOperation);
11181118
}
1119-
// TODO(ecoal95): Validate more parameters
1120-
1119+
// TODO(emilio): Validate more parameters
11211120
let source = match source {
11221121
Some(s) => s,
11231122
None => return,
@@ -1144,7 +1143,7 @@ impl WebGLRenderingContextMethods for WebGLRenderingContext {
11441143
};
11451144

11461145
let size = Size2D::new(img.width as i32, img.height as i32);
1147-
// TODO(ecoal95): Validate that the format argument is coherent with the image.
1146+
// TODO(emilio): Validate that the format argument is coherent with the image.
11481147
// RGB8 should be easy to support too
11491148
let mut data = match img.format {
11501149
PixelFormat::RGBA8 => img.bytes.to_vec(),
@@ -1155,7 +1154,7 @@ impl WebGLRenderingContextMethods for WebGLRenderingContext {
11551154

11561155
(data, size)
11571156
},
1158-
// TODO(ecoal95): Getting canvas data is implemented in CanvasRenderingContext2D, but
1157+
// TODO(emilio): Getting canvas data is implemented in CanvasRenderingContext2D, but
11591158
// we need to refactor it moving it to `HTMLCanvasElement` and supporting WebGLContext
11601159
ImageDataOrHTMLImageElementOrHTMLCanvasElementOrHTMLVideoElement::HTMLCanvasElement(canvas) => {
11611160
let canvas = canvas.r();
@@ -1170,7 +1169,7 @@ impl WebGLRenderingContextMethods for WebGLRenderingContext {
11701169
=> unimplemented!(),
11711170
};
11721171

1173-
// TODO(ecoal95): Invert axis, convert colorspace, premultiply alpha if requested
1172+
// TODO(emilio): Invert axis, convert colorspace, premultiply alpha if requested
11741173
let msg = CanvasWebGLMsg::TexImage2D(target, level, internal_format as i32,
11751174
size.width, size.height,
11761175
format, data_type, pixels);

components/style/selector_matching.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -266,7 +266,7 @@ impl<Impl: SelectorImplExt> Stylist<Impl> {
266266
let map = match pseudo_element {
267267
Some(ref pseudo) => match self.pseudos_map.get(pseudo) {
268268
Some(map) => map,
269-
// TODO(ecoal95): get non eagerly-cascaded pseudo-element rules here.
269+
// TODO(emilio): get non eagerly-cascaded pseudo-element rules here.
270270
// Actually assume there are no rules applicable.
271271
None => return true,
272272
},

tests/wpt/web-platform-tests/XMLHttpRequest/OWNERS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
@ecoal95
1+
@emilio
22
@hallvors
33
@kangxu
44
@caitp

0 commit comments

Comments
 (0)