Print action requests from our subtree

lukewarlow · delan · delan · commit 64041ee39449 · 2026-01-13T17:04:45.000+08:00
Co-authored-by: Delan Azabani &lt;dazabani@igalia.com&gt;
Signed-off-by: Luke Warlow &lt;lwarlow@igalia.com&gt;
diff --git a/components/layout/accessibility_tree.rs b/components/layout/accessibility_tree.rs
@@ -6,7 +6,7 @@ use std::rc::Rc;
 use std::sync::LazyLock;
 
 pub(crate) use accessibility_traits::AccessibilityTree;
-use accesskit::{Node as AxNode, NodeId as AxNodeId, Role, Tree as AxTree};
+use accesskit::{Action, Node as AxNode, NodeId as AxNodeId, Role, Tree as AxTree};
 use html5ever::{LocalName, local_name};
 use layout_api::wrapper_traits::{LayoutNode, ThreadSafeLayoutNode};
 use log::trace;
@@ -77,6 +77,7 @@ impl AccessibilityTreeCalculator {
                     }
                 }
             }
+            ax_next.add_action(Action::Click);
             ax_nodes.insert(ax_next_id, ax_next);
         }
         AccessibilityTree {
diff --git a/ports/servoshell/desktop/app.rs b/ports/servoshell/desktop/app.rs
@@ -213,7 +213,7 @@ impl ApplicationHandler<AppEvent> for App {
             .and_then(|window_id| state.window(ServoShellWindowId::from(u64::from(window_id))))
         {
             if let Some(headed_window) = window.platform_window().as_headed_window() {
-                headed_window.handle_winit_app_event(app_event);
+                headed_window.handle_winit_app_event(&window, app_event);
             }
         }
 
diff --git a/ports/servoshell/desktop/headed_window.rs b/ports/servoshell/desktop/headed_window.rs
@@ -758,8 +758,21 @@ impl HeadedWindow {
         }
     }
 
-    pub(crate) fn handle_winit_app_event(&self, app_event: AppEvent) {
+    pub(crate) fn handle_winit_app_event(&self, _window: &ServoShellWindow, app_event: AppEvent) {
         if let AppEvent::Accessibility(ref event) = app_event {
+            match &event.window_event {
+                egui_winit::accesskit_winit::WindowEvent::InitialTreeRequested => {
+                    // TODO get the initial tree from servo
+                },
+                egui_winit::accesskit_winit::WindowEvent::ActionRequested(req) => {
+                    // TODO use window to get active webview, then do something with action request.
+                    if req.target_tree != TreeId::ROOT {
+                        println!("{:?}", req);
+                    }
+                },
+                _ => {},
+            }
+
             if self
                 .gui
                 .borrow_mut()

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@ use std::rc::Rc;`
`6`	`6`	`use std::sync::LazyLock;`
`7`	`7`
`8`	`8`	`pub(crate) use accessibility_traits::AccessibilityTree;`
`9`		`-use accesskit::{Node as AxNode, NodeId as AxNodeId, Role, Tree as AxTree};`
	`9`	`+use accesskit::{Action, Node as AxNode, NodeId as AxNodeId, Role, Tree as AxTree};`
`10`	`10`	`use html5ever::{LocalName, local_name};`
`11`	`11`	`use layout_api::wrapper_traits::{LayoutNode, ThreadSafeLayoutNode};`
`12`	`12`	`use log::trace;`
`@@ -77,6 +77,7 @@ impl AccessibilityTreeCalculator {`
`77`	`77`	`}`
`78`	`78`	`}`
`79`	`79`	`}`
	`80`	`+ ax_next.add_action(Action::Click);`
`80`	`81`	`ax_nodes.insert(ax_next_id, ax_next);`
`81`	`82`	`}`
`82`	`83`	`AccessibilityTree {`
Original file line number	Diff line number	Diff line change
`@@ -213,7 +213,7 @@ impl ApplicationHandler<AppEvent> for App {`
`213`	`213`	`.and_then(\|window_id\| state.window(ServoShellWindowId::from(u64::from(window_id))))`
`214`	`214`	`{`
`215`	`215`	`if let Some(headed_window) = window.platform_window().as_headed_window() {`
`216`		`- headed_window.handle_winit_app_event(app_event);`
	`216`	`+ headed_window.handle_winit_app_event(&window, app_event);`
`217`	`217`	`}`
`218`	`218`	`}`
`219`	`219`